Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make access group schema for gsuite required #4597

Merged
merged 2 commits into from
Nov 22, 2024

Conversation

BSFishy
Copy link
Contributor

@BSFishy BSFishy commented Nov 18, 2024

According to https://developers.cloudflare.com/api/operations/access-policies-create-an-access-policy, email and identity_provider_id are both required in the body of the request, but the terraform schema lists them as optional

Copy link
Contributor

github-actions bot commented Nov 18, 2024

changelog detected ✅

@BSFishy BSFishy marked this pull request as ready for review November 18, 2024 16:24
@jacobbednarz
Copy link
Member

acceptance tests look good

TF_ACC=1 go test ./internal/sdkv2provider -v -run "^TestAccCloudflareAccessPolicy_" -count 1 -timeout 120m -parallel 1
=== RUN   TestAccCloudflareAccessPolicy_ServiceToken
--- PASS: TestAccCloudflareAccessPolicy_ServiceToken (8.27s)
=== RUN   TestAccCloudflareAccessPolicy_AnyServiceToken
--- PASS: TestAccCloudflareAccessPolicy_AnyServiceToken (4.06s)
=== RUN   TestAccCloudflareAccessPolicy_WithZoneID
--- PASS: TestAccCloudflareAccessPolicy_WithZoneID (6.57s)
=== RUN   TestAccCloudflareAccessPolicy_Group
--- PASS: TestAccCloudflareAccessPolicy_Group (4.84s)
=== RUN   TestAccCloudflareAccessPolicy_MTLS
--- PASS: TestAccCloudflareAccessPolicy_MTLS (4.45s)
=== RUN   TestAccCloudflareAccessPolicy_CommonName
--- PASS: TestAccCloudflareAccessPolicy_CommonName (4.38s)
=== RUN   TestAccCloudflareAccessPolicy_EmailDomain
--- PASS: TestAccCloudflareAccessPolicy_EmailDomain (4.51s)
=== RUN   TestAccCloudflareAccessPolicy_Emails
--- PASS: TestAccCloudflareAccessPolicy_Emails (9.39s)
=== RUN   TestAccCloudflareAccessPolicy_Everyone
--- PASS: TestAccCloudflareAccessPolicy_Everyone (4.40s)
=== RUN   TestAccCloudflareAccessPolicy_IPs
--- PASS: TestAccCloudflareAccessPolicy_IPs (4.43s)
=== RUN   TestAccCloudflareAccessPolicy_AuthMethod
--- PASS: TestAccCloudflareAccessPolicy_AuthMethod (4.30s)
=== RUN   TestAccCloudflareAccessPolicy_Geo
--- PASS: TestAccCloudflareAccessPolicy_Geo (9.15s)
=== RUN   TestAccCloudflareAccessPolicy_Okta
--- PASS: TestAccCloudflareAccessPolicy_Okta (4.32s)
=== RUN   TestAccCloudflareAccessPolicy_PurposeJustification
--- PASS: TestAccCloudflareAccessPolicy_PurposeJustification (4.48s)
=== RUN   TestAccCloudflareAccessPolicy_ApprovalGroup
--- PASS: TestAccCloudflareAccessPolicy_ApprovalGroup (4.50s)
=== RUN   TestAccCloudflareAccessPolicy_Reusable
--- PASS: TestAccCloudflareAccessPolicy_Reusable (2.10s)
=== RUN   TestAccCloudflareAccessPolicy_ExternalEvaluation
--- PASS: TestAccCloudflareAccessPolicy_ExternalEvaluation (4.39s)
=== RUN   TestAccCloudflareAccessPolicy_ConnectionRules
--- PASS: TestAccCloudflareAccessPolicy_ConnectionRules (4.30s)
=== RUN   TestAccCloudflareAccessPolicy_IsolationRequired
--- PASS: TestAccCloudflareAccessPolicy_IsolationRequired (10.09s)
PASS
ok  	github.com/cloudflare/terraform-provider-cloudflare/internal/sdkv2provider	104.105s

@jacobbednarz jacobbednarz merged commit f61924a into cloudflare:master Nov 22, 2024
6 checks passed
@github-actions github-actions bot added this to the v4.47.0 milestone Nov 22, 2024
@BSFishy BSFishy deleted the gsuite_required branch November 23, 2024 01:53
Copy link
Contributor

This functionality has been released in v4.47.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants