Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FLPROD-796: Register snippet and snippet_rules resources #4565

Merged
merged 5 commits into from
Dec 5, 2024

Conversation

WowVeryLogin
Copy link
Contributor

@WowVeryLogin WowVeryLogin commented Nov 12, 2024

Copy link
Contributor

changelog detected ✅

@jacobbednarz
Copy link
Member

cloudflare_snippet looks fine

TF_ACC=1 go test ./internal/framework/service/snippets/ -run "^TestAcc" -count 1 -v
=== RUN   TestAccCloudflareSnippet
=== PAUSE TestAccCloudflareSnippet
=== CONT  TestAccCloudflareSnippet
--- PASS: TestAccCloudflareSnippet (5.15s)
PASS
ok  	github.com/cloudflare/terraform-provider-cloudflare/internal/framework/service/snippets	6.389s

however, cloudflare_snippet_rules is having issues with the decoding of the json

=== RUN   TestAccCloudflareSnippetRules
=== PAUSE TestAccCloudflareSnippetRules
=== CONT  TestAccCloudflareSnippetRules
    resource_test.go:55: Step 1/2 error: Error running apply: exit status 1
        
        Error: failed to create snippet rules
        
          with cloudflare_snippet_rules.qciadqjjip,
          on terraform_plugin_test.tf line 12, in resource "cloudflare_snippet_rules" "qciadqjjip":
          12:   resource "cloudflare_snippet_rules" "qciadqjjip" {
        
        can not decode parameters json
--- FAIL: TestAccCloudflareSnippetRules (0.90s)
FAIL
FAIL	github.com/cloudflare/terraform-provider-cloudflare/internal/framework/service/snippet_rules	2.144s
FAIL

@WowVeryLogin
Copy link
Contributor Author

Yeah, it's the answer from snippets-api service. Should be fixed with: cloudflare/cloudflare-go#3669

@jacobbednarz
Copy link
Member

ah, so there is another dependent PR. sorry, missed that.

@travisby

This comment was marked as spam.

@jacobbednarz
Copy link
Member

acceptance tests all passing here

=== RUN   TestAccCloudflareSnippetRules
=== PAUSE TestAccCloudflareSnippetRules
=== CONT  TestAccCloudflareSnippetRules
--- PASS: TestAccCloudflareSnippetRules (14.26s)
PASS
ok  	github.com/cloudflare/terraform-provider-cloudflare/internal/framework/service/snippet_rules	15.629s

@jacobbednarz jacobbednarz merged commit 4a99153 into cloudflare:master Dec 5, 2024
7 checks passed
@github-actions github-actions bot added this to the v4.48.0 milestone Dec 5, 2024
Copy link
Contributor

This functionality has been released in v4.48.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants