Add deprecation notice for zone, take 2
#452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have been working to perform some breaking changes in cloudflare#227 and the first attempt at this in cloudflare#421 neglected to allow people to set `zone_id` and action the deprecation notice 🤦 This second attempt has the same goal of deprecating `zone` in favour of explicit `zone_id` however this time I've updated both schema properties to be optional and added some validation in the various `Create` methods to ensure that we get at least one of them during the swap over period. That code can be removed as soon we've cut a breaking change release. Closes cloudflare#439
ghost
added
the
patryk
approved these changes
Aug 22, 2019
syed-awais-ali
referenced
this pull request
in syed-awais-ali/terraform-provider-cloudflare
Sep 16, 2019
Since zone is deprecated in favour of explicit zone_id which is settable so I have updated the docs to reflect the same change https://github.com/terraform-providers/terraform-provider-cloudflare/pull/452
patryk
referenced
this pull request
Sep 16, 2019
Since zone is deprecated in favour of explicit zone_id which is settable so I have updated the docs to reflect the same change https://github.com/terraform-providers/terraform-provider-cloudflare/pull/452
boekkooi-lengoo
pushed a commit
to boekkooi-lengoo/terraform-provider-cloudflare
that referenced
this pull request
Feb 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have been working to perform some breaking changes in #227 and the
first attempt at this in #421 neglected to allow people to set
zone_idand action the deprecation notice 🤦
This second attempt has the same goal of deprecating
zonein favour ofexplicit
zone_idhowever this time I've updated both schema propertiesto be optional and added some validation in the various
Createmethodsto ensure that we get at least one of them during the swap over period.
That code can be removed as soon we've cut a breaking change release.
Closes #439