Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DLP-2423: Include more fields in 'entry' set hash function in cloudflare_zero_trust_dlp_profile #4464

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

OrionNebula
Copy link

Currently, the custom set hash function on values in the entry set only uses the name field. Start using every field (except ID) to properly detect changes to more fields without causing plan instability

Copy link
Contributor

changelog detected ✅

@jacobbednarz
Copy link
Member

acceptance tests look good

TF_ACC=1 go test ./internal/sdkv2provider -v -run "^TestAccCloudflareDLPProfile_" -count 1 -timeout 120m -parallel 1
=== RUN   TestAccCloudflareDLPProfile_Custom
--- PASS: TestAccCloudflareDLPProfile_Custom (2.93s)
=== RUN   TestAccCloudflareDLPProfile_Custom_MultipleEntries
--- PASS: TestAccCloudflareDLPProfile_Custom_MultipleEntries (2.23s)
=== RUN   TestAccCloudflareDLPProfile_CustomWithAllowedMatchCount
--- PASS: TestAccCloudflareDLPProfile_CustomWithAllowedMatchCount (2.16s)
=== RUN   TestAccCloudflareDLPProfile_CustomWithOCREnabled
--- PASS: TestAccCloudflareDLPProfile_CustomWithOCREnabled (2.13s)
=== RUN   TestAccCloudflareDLPProfile_ContextAwareness
--- PASS: TestAccCloudflareDLPProfile_ContextAwareness (2.13s)
PASS
ok  	github.com/cloudflare/terraform-provider-cloudflare/internal/sdkv2provider	12.831s

@jacobbednarz jacobbednarz merged commit 9874530 into cloudflare:master Oct 29, 2024
8 checks passed
@github-actions github-actions bot added this to the v4.45.0 milestone Oct 29, 2024
Copy link
Contributor

This functionality has been released in v4.45.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants