Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #429 SSL: adding support for origin_pull setting #430

Merged
merged 4 commits into from
Jul 25, 2019

Conversation

elan-devops
Copy link
Contributor

Adding "origin_pull" SSL pageActionRule for Cloudflare Enterprise support.
Issue
[Cloudflare ssl] https://support.cloudflare.com/hc/en-us/articles/200170416

@jacobbednarz
Copy link
Member

This code change looks good. We will also want to update the page_rule resource documentation that is shown on the website (it is found at https://github.com/terraform-providers/terraform-provider-cloudflare/blob/master/website/docs/r/page_rule.html.markdown). Once that's added, we can 🚢 this.

@elan-devops
Copy link
Contributor Author

elan-devops commented Jul 25, 2019

Sure @jacobbednarz. One more qq, this is a blocker for the feature that I am working with my current project at my company. We are using Terraform v0.11.13 Enterprise version. How do I make this change go in our usage?

@jacobbednarz
Copy link
Member

v0.11.13 is the terraform version whereas this will update the provider which is currently v1.16.1 (terraform is "core" whereas "providers" are plugins for the core). Once this is merged, it will be a part of the next release and you can update to it by re-running terraform init.

If you can't wait for us to cut a release, you can pull the code locally and run it yourself. Instructions can be found at https://github.com/terraform-providers/terraform-provider-cloudflare#building-the-provider.

@ghost ghost added the kind/documentation Categorizes issue or PR as related to documentation. label Jul 25, 2019
@jacobbednarz jacobbednarz merged commit 4465248 into cloudflare:master Jul 25, 2019
@jacobbednarz
Copy link
Member

Thank you for the contribution @elan-devops! You rock! 🤘

@elan-devops
Copy link
Contributor Author

Thanks for all your help @jacobbednarz. Have a good rest of your day!

boekkooi-lengoo pushed a commit to boekkooi-lengoo/terraform-provider-cloudflare that referenced this pull request Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/documentation Categorizes issue or PR as related to documentation. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants