Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update website/docs/r/logpush_job.html.markdown #395

Merged
merged 2 commits into from
Jun 28, 2019

Conversation

fclerg
Copy link

@fclerg fclerg commented Jun 27, 2019

  • Fixing confusing name field in the example as it must not contain spaces
  • Adding missing required field and their description.
  • Removing import section as it is not supported for this resource. Error message when trying to run an import :
cloudflare_logpush_job.example_job: Importing from ID "a9c1ccd9b3d737cc0a83e54226b6e96d/6080"...

Error: cloudflare_logpush_job.example_job (import id: a9c1ccd9b3d537cc0a63e54226b6e96d/6070): import cloudflare_logpush_job.example_job (id: a9c1ccd9b3d537cc0a63e54226b6e96d/6080): resource cloudflare_logpush_job doesn't support import

@ghost ghost added size/XS kind/documentation Categorizes issue or PR as related to documentation. labels Jun 27, 2019
@fclerg
Copy link
Author

fclerg commented Jun 27, 2019

applied your suggested changes @jacobbednarz, thanks. Not sure why had to open a new PR, sorry about that.

@jimbobjim123
Copy link

Looking at the commit we are also removing the import logpush job option from the docs. Is this not supported anymore? Has it ever been an option?

@fclerg
Copy link
Author

fclerg commented Jun 28, 2019

As mentioned above here is the message I get when trying to import a logpush resource :

cloudflare_logpush_job.example_job: Importing from ID "a9c1ccd9b3d737cc0a83e54226b6e96d/6080"...

Error: cloudflare_logpush_job.example_job (import id: a9c1ccd9b3d537cc0a63e54226b6e96d/6070): import cloudflare_logpush_job.example_job (id: a9c1ccd9b3d537cc0a63e54226b6e96d/6080): resource cloudflare_logpush_job doesn't support import

Not sure if it has ever been supported. I guess not as the cloudflare_logpush_job resource has been introduced quite recently (see issue #210)

@jacobbednarz
Copy link
Member

Logpush doesn’t have support for importing at the moment.

Copy link
Member

@jacobbednarz jacobbednarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jacobbednarz jacobbednarz merged commit 38f3e5c into cloudflare:master Jun 28, 2019
@jacobbednarz
Copy link
Member

Thank you @fclerg!

boekkooi-lengoo pushed a commit to boekkooi-lengoo/terraform-provider-cloudflare that referenced this pull request Feb 28, 2022
…cloudflare#395)

* update SpectrumApplication to support string value for proxy_protocol
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/documentation Categorizes issue or PR as related to documentation. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants