-
Notifications
You must be signed in to change notification settings - Fork 630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update website/docs/r/logpush_job.html.markdown #395
Conversation
fclerg
commented
Jun 27, 2019
- Fixing confusing name field in the example as it must not contain spaces
- Adding missing required field and their description.
- Removing import section as it is not supported for this resource. Error message when trying to run an import :
applied your suggested changes @jacobbednarz, thanks. Not sure why had to open a new PR, sorry about that. |
Looking at the commit we are also removing the import logpush job option from the docs. Is this not supported anymore? Has it ever been an option? |
As mentioned above here is the message I get when trying to import a logpush resource :
Not sure if it has ever been supported. I guess not as the cloudflare_logpush_job resource has been introduced quite recently (see issue #210) |
Logpush doesn’t have support for importing at the moment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you @fclerg! |
…cloudflare#395) * update SpectrumApplication to support string value for proxy_protocol