Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add hyperdrive_config_binding to Cloudflare Workers #3821

Merged
merged 6 commits into from
Sep 18, 2024

Conversation

OilyLime
Copy link
Contributor

No description provided.

@OilyLime OilyLime requested a review from jacobbednarz as a code owner August 28, 2024 20:15
Copy link
Contributor

This project handles dependency version bumps (including upstream changes from cloudflare-go) independently of the standard PR process using automation. This allows the dependency upgrades to land without causing merge conflicts in multiple branches and handled in a consistent way. The exception to this is security related dependency upgrades but they should be co-ordinated with the maintainer team privately.

Please remove the changes to the go.mod or go.sum files from this PR in order to proceed with review and merging.

Copy link
Contributor

github-actions bot commented Aug 28, 2024

changelog detected ✅

Copy link
Contributor

Marking this pull request as stale due to 14 days of inactivity. This helps our maintainers find and focus on the active pull requests. If this pull request receives no comments in the next 7 days it will automatically be closed. Maintainers can also remove the lifecycle/stale label.
If this pull request was automatically closed and you feel this pull request should be reopened, we encourage creating a new pull request linking back to this one for added context. Thank you!

@OilyLime
Copy link
Contributor Author

Hey @jacobbednarz, like we discussed, can you help me get the Hyperdrive config IDs to this PR so that we can get the tests passing and push this guy through?

@jacobbednarz
Copy link
Member

i've got ahead and dropped the secrets in place for the tests to start using - https://github.com/cloudflare/terraform-provider-cloudflare/blob/master/.github/workflows/acceptance-tests.yml#L44-L48

we'll need to remove the version bumps from this PR to have it apply cleanly though.

@jacobbednarz
Copy link
Member

jacobbednarz commented Sep 17, 2024

hyperdrive ID is d08bc4a1c3c140aa95e4ceec535f832e

@OilyLime OilyLime force-pushed the hyperdrive-worker-binding branch from e1c900c to 0060121 Compare September 17, 2024 18:46
@jacobbednarz
Copy link
Member

acceptance tests all passing

TF_ACC=1 go test ./internal/sdkv2provider -v -run "^TestAccCloudflareWorkerScript_" -count 1 -timeout 120m -parallel 1
=== RUN   TestAccCloudflareWorkerScript_Import
--- PASS: TestAccCloudflareWorkerScript_Import (5.49s)
=== RUN   TestAccCloudflareWorkerScript_MultiScriptEnt
=== PAUSE TestAccCloudflareWorkerScript_MultiScriptEnt
=== RUN   TestAccCloudflareWorkerScript_ModuleUpload
=== PAUSE TestAccCloudflareWorkerScript_ModuleUpload
=== CONT  TestAccCloudflareWorkerScript_MultiScriptEnt
--- PASS: TestAccCloudflareWorkerScript_MultiScriptEnt (20.22s)
=== CONT  TestAccCloudflareWorkerScript_ModuleUpload
--- PASS: TestAccCloudflareWorkerScript_ModuleUpload (12.81s)
PASS
ok  	github.com/cloudflare/terraform-provider-cloudflare/internal/sdkv2provider	39.550s

@jacobbednarz jacobbednarz merged commit 3a4df23 into cloudflare:master Sep 18, 2024
9 checks passed
@github-actions github-actions bot added this to the v4.42.0 milestone Sep 18, 2024
Copy link
Contributor

This functionality has been released in v4.42.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants