Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test/load_balancer_pool: Update IP range for tests #369

Merged
merged 1 commit into from
Jun 6, 2019

Conversation

jacobbednarz
Copy link
Member

Updates the address values to not use ranges that the IETF reserve for
documentation and example purposes
as these fail load balancer
validation.

@ghost ghost added the size/XS label Jun 5, 2019
Updates the `address` values to not use ranges that the IETF reserve for
documentation and example purposes[1] as these fail load balancer
validation.

[1]: https://tools.ietf.org/html/rfc5737
@patryk patryk merged commit a3ff1aa into cloudflare:master Jun 6, 2019
@jacobbednarz jacobbednarz deleted the update-ip-used branch June 6, 2019 00:08
boekkooi-lengoo pushed a commit to boekkooi-lengoo/terraform-provider-cloudflare that referenced this pull request Feb 28, 2022
…e#369)

Previously, creating or updating a worker route would default to the deprecated `filters` endpoints when Enabled == false and ScriptName == "". This would cause errors when using API tokens since the filter endpoints don't support API tokens. This change will use the `routes` endpoints in that scenario instead, which do support API tokens.

It also updates `ListWorkerRoutes` to use the `routes` endpoint instead of `filters` when an API token is supplied.

Deleting worker routes suffers from the same problem, but that will be fixed in cloudflare#367
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants