Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle multiple okta idps in access policies #3579

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

BSFishy
Copy link
Contributor

@BSFishy BSFishy commented Aug 7, 2024

Fix handling of multiple Okta IDPs in access policies. This roughly follows the flow that Azure AD does.

fixes #3425

Copy link
Contributor

github-actions bot commented Aug 7, 2024

changelog detected ✅

@BSFishy BSFishy force-pushed the access_policy_okta branch from dc20fbb to 8c9c810 Compare August 7, 2024 19:22
@BSFishy BSFishy marked this pull request as ready for review August 7, 2024 19:31
@BSFishy BSFishy requested a review from jacobbednarz as a code owner August 7, 2024 19:31
@jacobbednarz
Copy link
Member

acceptance tests all passing

TF_ACC=1 go test ./internal/sdkv2provider -v -run "^TestAccCloudflareAccessGroup_" -count 1 -timeout 120m -parallel 1
=== RUN   TestAccCloudflareAccessGroup_ConfigBasicZone
--- PASS: TestAccCloudflareAccessGroup_ConfigBasicZone (4.37s)
=== RUN   TestAccCloudflareAccessGroup_ConfigBasicAccount
--- PASS: TestAccCloudflareAccessGroup_ConfigBasicAccount (4.94s)
=== RUN   TestAccCloudflareAccessGroup_ConfigEmailList
--- PASS: TestAccCloudflareAccessGroup_ConfigEmailList (8.81s)
=== RUN   TestAccCloudflareAccessGroup_Exclude
--- PASS: TestAccCloudflareAccessGroup_Exclude (3.19s)
=== RUN   TestAccCloudflareAccessGroup_Require
--- PASS: TestAccCloudflareAccessGroup_Require (3.03s)
=== RUN   TestAccCloudflareAccessGroup_FullConfig
--- PASS: TestAccCloudflareAccessGroup_FullConfig (5.94s)
=== RUN   TestAccCloudflareAccessGroup_WithIDP
--- PASS: TestAccCloudflareAccessGroup_WithIDP (5.80s)
=== RUN   TestAccCloudflareAccessGroup_WithIDPAuthContext
--- PASS: TestAccCloudflareAccessGroup_WithIDPAuthContext (6.50s)
=== RUN   TestAccCloudflareAccessGroup_Updated
--- PASS: TestAccCloudflareAccessGroup_Updated (4.60s)
=== RUN   TestAccCloudflareAccessGroup_CreateAfterManualDestroy
--- PASS: TestAccCloudflareAccessGroup_CreateAfterManualDestroy (5.04s)
=== RUN   TestAccCloudflareAccessGroup_UpdatedFromCommonNameToCommonNames
--- PASS: TestAccCloudflareAccessGroup_UpdatedFromCommonNameToCommonNames (21.15s)
PASS
ok  	github.com/cloudflare/terraform-provider-cloudflare/internal/sdkv2provider	74.493s

@jacobbednarz jacobbednarz merged commit 751fdf3 into cloudflare:master Aug 9, 2024
10 checks passed
@github-actions github-actions bot added this to the v4.40.0 milestone Aug 9, 2024
@BSFishy BSFishy deleted the access_policy_okta branch August 9, 2024 17:00
Copy link
Contributor

This functionality has been released in v4.40.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[AccessPolicy] Incorrect management of "require" with multiple Okta IdPs
2 participants