Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support admin code override disable_for_time field #3526

Merged

Conversation

da-cf
Copy link
Contributor

@da-cf da-cf commented Jul 31, 2024

Adds support for the disable_for_time field for the admin override feature

Relies on a cloudflare-go PR

@da-cf da-cf requested a review from jacobbednarz as a code owner July 31, 2024 00:01
Copy link
Contributor

github-actions bot commented Jul 31, 2024

changelog detected ✅

@da-cf da-cf force-pushed the support-override-device-global-settings branch from 2006e90 to 4446121 Compare July 31, 2024 00:26
Copy link
Contributor

Marking this pull request as stale due to 14 days of inactivity. This helps our maintainers find and focus on the active pull requests. If this pull request receives no comments in the next 7 days it will automatically be closed. Maintainers can also remove the lifecycle/stale label.
If this pull request was automatically closed and you feel this pull request should be reopened, we encourage creating a new pull request linking back to this one for added context. Thank you!

.changelog/3526.txt Outdated Show resolved Hide resolved
@jacobbednarz
Copy link
Member

acceptance tests look good

TF_ACC=1 go test ./internal/sdkv2provider -v -run "^TestAccCloudflareTeamsAccounts_" -count 1 -timeout 120m -parallel 1
=== RUN   TestAccCloudflareTeamsAccounts_ConfigurationBasic
--- PASS: TestAccCloudflareTeamsAccounts_ConfigurationBasic (6.89s)
PASS
ok  	github.com/cloudflare/terraform-provider-cloudflare/internal/sdkv2provider	7.916s

@jacobbednarz
Copy link
Member

@ajholland are you able to look at fixing the access application changes in v0.102.0 that are breaking CI here?

@jacobbednarz jacobbednarz merged commit d3cc413 into cloudflare:master Sep 2, 2024
9 checks passed
@github-actions github-actions bot added this to the v4.41.0 milestone Sep 2, 2024
Copy link
Contributor

github-actions bot commented Sep 4, 2024

This functionality has been released in v4.41.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants