Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cloudflare_access_policy requiring explictly either account id or zone id #3352

Merged
merged 2 commits into from
Jun 11, 2024

Conversation

GreenStage
Copy link
Contributor

@GreenStage GreenStage commented Jun 10, 2024

on 4.34 I've introduced a bug by changing ConflictsWith to ExactlyOneOf. Some customers are still have some tf scripts without the account_id in the terraform policy, so it is now breaking.

I think we do not support omitting account_id in favor of CLOUDFLARE_ACCOUNT_ID anymore anyway, but that fails on create, not on validation for untouched resources.

@GreenStage GreenStage requested a review from jacobbednarz as a code owner June 10, 2024 11:39
Copy link
Contributor

github-actions bot commented Jun 10, 2024

changelog detected ✅

@GreenStage GreenStage force-pushed the egomes/fix-policy-accid branch from 9fd18e8 to dcbdaaf Compare June 10, 2024 11:41
@jacobbednarz jacobbednarz merged commit 4b20d2d into cloudflare:master Jun 11, 2024
9 checks passed
@github-actions github-actions bot added this to the v4.35.0 milestone Jun 11, 2024
github-actions bot pushed a commit that referenced this pull request Jun 11, 2024
Copy link
Contributor

This functionality has been released in v4.35.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants