Mirror API record_delimiter defaults #3334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to https://developers.cloudflare.com/logs/reference/log-output-options/ the default options for record_suffix are "}\n" and not "}" The defaults cause malformed JSON when there is more than a single record in a time interval. Perhaps a better default would be to set record_delimiter to "\n" and keep field_delimiter "}" but this change is intended to mirror the published documentation
|
changelog detected ✅ |
|
This looks good to me and matches public docs for NDJSON.
|
cmackenzie1
approved these changes
May 30, 2024
|
This functionality has been released in v4.35.0 of the Terraform Cloudflare Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to https://developers.cloudflare.com/logs/reference/log-output-options/ the default options for record_suffix are "}\n" and not "}" The defaults cause malformed JSON when there is more than a single record in a time interval.
Perhaps a better default would be to set record_delimiter to "\n" and keep field_delimiter "}" but this change is intended to mirror the published documentation