Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DLP-1800: terraform support for user risk scoring #3307

Merged

Conversation

inanna-malick
Copy link

@inanna-malick inanna-malick commented May 14, 2024

filing PR for initial review.

Copy link
Contributor

This project handles dependency version bumps (including upstream changes from cloudflare-go) independently of the standard PR process using automation. This allows the dependency upgrades to land without causing merge conflicts in multiple branches and handled in a consistent way. The exception to this is security related dependency upgrades but they should be co-ordinated with the maintainer team privately.

Please remove the changes to the go.mod or go.sum files from this PR in order to proceed with review and merging.

Copy link
Contributor

github-actions bot commented May 14, 2024

changelog detected ✅

@inanna-malick inanna-malick force-pushed the inanna/DLP-1800-user-risk-scoring branch 2 times, most recently from 6d62498 to da8de2f Compare May 14, 2024 16:11
@inanna-malick inanna-malick force-pushed the inanna/DLP-1800-user-risk-scoring branch 2 times, most recently from 71068b1 to 7ef9a81 Compare May 16, 2024 16:47
@inanna-malick inanna-malick force-pushed the inanna/DLP-1800-user-risk-scoring branch from 7ef9a81 to f53e38b Compare May 16, 2024 16:50
@jacobbednarz
Copy link
Member

acceptance tests look good

TF_ACC=1 go test ./internal/framework/service/risk_behavior -v -run "^TestAccCloudflareRiskBehavior_" -count 1 -timeout 120m -parallel 1
=== RUN   TestAccCloudflareRiskBehavior_Basic
=== PAUSE TestAccCloudflareRiskBehavior_Basic
=== CONT  TestAccCloudflareRiskBehavior_Basic
--- PASS: TestAccCloudflareRiskBehavior_Basic (10.02s)
PASS
ok  	github.com/cloudflare/terraform-provider-cloudflare/internal/framework/service/risk_behavior	11.313s

@jacobbednarz jacobbednarz merged commit 54329e1 into cloudflare:master May 17, 2024
7 of 8 checks passed
@github-actions github-actions bot added this to the v4.34.0 milestone May 17, 2024
github-actions bot pushed a commit that referenced this pull request May 17, 2024
@inanna-malick inanna-malick deleted the inanna/DLP-1800-user-risk-scoring branch May 17, 2024 16:18
Copy link
Contributor

This functionality has been released in v4.34.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants