Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for email_list in Access Group resources #3247

Merged

Conversation

tv
Copy link
Contributor

@tv tv commented Apr 16, 2024

Adds support for using email_lists inside the access groups. The parameter is documented here in the API.

There was a discussion about this here. Issue was closed as it was pending the cloudflare-go support which has been released quite some time ago already.

@tv tv requested a review from jacobbednarz as a code owner April 16, 2024 10:38
Copy link
Contributor

github-actions bot commented Apr 16, 2024

changelog detected ✅

Copy link
Contributor

github-actions bot commented May 2, 2024

Marking this pull request as stale due to 14 days of inactivity. This helps our maintainers find and focus on the active pull requests. If this pull request receives no comments in the next 7 days it will automatically be closed. Maintainers can also remove the lifecycle/stale label.
If this pull request was automatically closed and you feel this pull request should be reopened, we encourage creating a new pull request linking back to this one for added context. Thank you!

@tv tv force-pushed the feat-email-list-access-group-resource branch from 8885d6c to 535c46e Compare May 2, 2024 08:27
@jacobbednarz
Copy link
Member

thanks! acceptance tests are now passing

TF_ACC=1 go test ./internal/sdkv2provider -v -run "^TestAccCloudflareAccessGroup_" -count 1 -timeout 120m -parallel 1
=== RUN   TestAccCloudflareAccessGroup_ConfigBasicZone
--- PASS: TestAccCloudflareAccessGroup_ConfigBasicZone (13.91s)
=== RUN   TestAccCloudflareAccessGroup_ConfigBasicAccount
--- PASS: TestAccCloudflareAccessGroup_ConfigBasicAccount (17.97s)
=== RUN   TestAccCloudflareAccessGroup_ConfigEmailList
--- PASS: TestAccCloudflareAccessGroup_ConfigEmailList (10.46s)
=== RUN   TestAccCloudflareAccessGroup_Exclude
--- PASS: TestAccCloudflareAccessGroup_Exclude (10.00s)
=== RUN   TestAccCloudflareAccessGroup_Require
--- PASS: TestAccCloudflareAccessGroup_Require (8.51s)
=== RUN   TestAccCloudflareAccessGroup_FullConfig
--- PASS: TestAccCloudflareAccessGroup_FullConfig (8.94s)
=== RUN   TestAccCloudflareAccessGroup_WithIDP
--- PASS: TestAccCloudflareAccessGroup_WithIDP (11.71s)
=== RUN   TestAccCloudflareAccessGroup_WithIDPAuthContext
--- PASS: TestAccCloudflareAccessGroup_WithIDPAuthContext (10.20s)
=== RUN   TestAccCloudflareAccessGroup_Updated
--- PASS: TestAccCloudflareAccessGroup_Updated (14.60s)
=== RUN   TestAccCloudflareAccessGroup_CreateAfterManualDestroy
--- PASS: TestAccCloudflareAccessGroup_CreateAfterManualDestroy (14.82s)
=== RUN   TestAccCloudflareAccessGroup_UpdatedFromCommonNameToCommonNames
--- PASS: TestAccCloudflareAccessGroup_UpdatedFromCommonNameToCommonNames (15.13s)
PASS
ok  	github.com/cloudflare/terraform-provider-cloudflare/internal/sdkv2provider	137.398s

@jacobbednarz jacobbednarz merged commit e199537 into cloudflare:master May 6, 2024
9 checks passed
@github-actions github-actions bot added this to the v4.32.0 milestone May 6, 2024
github-actions bot pushed a commit that referenced this pull request May 6, 2024
Copy link
Contributor

github-actions bot commented May 8, 2024

This functionality has been released in v4.32.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants