resource/cloudflare_logpush_job: only set the value in state when it is defined #3188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
changelog detected ✅ |
…is defined Updates the state management to only set the `output_options` when it is defined and avoid a permadiff showing it always being removed
jacobbednarz
force-pushed
the
conditionally-set-output-options
branch
from
80e9f2d to
37e68c7
Compare
|
acceptance tests now passing where i originally found this error |
dloebl
reviewed
Mar 15, 2024
There was a problem hiding this comment.
Thanks @jacobbednarz! Good catch.
It works as expected on my side now.
Before (output_options not present):
$ terraform plan
Now (output_options not present):
$ terraform plan
|
This functionality has been released in v4.27.0 of the Terraform Cloudflare Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the state management to only set the
output_optionswhen it is defined and avoid a permadiff showing it always being removed.@dloebl as the implementor here, can you confirm this works on your side? preferably with real cases?