-
Notifications
You must be signed in to change notification settings - Fork 630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AUTH-5974 added saml_attribute_transform_jsonata for saas apps #3187
AUTH-5974 added saml_attribute_transform_jsonata for saas apps #3187
Conversation
changelog detected ✅ |
0dc0dd4
to
118f105
Compare
118f105
to
776d8d7
Compare
@@ -771,6 +773,8 @@ resource "cloudflare_access_application" "%[1]s" { | |||
name_id_format = "email" | |||
default_relay_state = "https://saas-app.example" | |||
name_id_transform_jsonata = "$substringBefore(email, '@') & '+sandbox@' & $substringAfter(email, '@')" | |||
saml_attribute_transform_jsonata = "$ ~>| groups | {'group_name': name} |" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is throwing invalid expression error atm
TF_ACC=1 go test ./internal/sdkv2provider -v -run "^TestAccCloudflareAccessApplication_WithSAMLSaas" -count 1 -timeout 120m -parallel 1
=== RUN TestAccCloudflareAccessApplication_WithSAMLSaas
resource_cloudflare_access_application_test.go:172: Step 1/1 error: Error running apply: exit status 1
Error: error creating Access Application for accounts "f037e56e89293a057740de681ac9abbe": error from makeRequest: access.api.error.invalid_request: saml_attribute_transform_jsonata jsonata expression is invalid (12130)
with cloudflare_access_application.apdysxmvfy,
on terraform_plugin_test.tf line 12, in resource "cloudflare_access_application" "apdysxmvfy":
12: resource "cloudflare_access_application" "apdysxmvfy" {
--- FAIL: TestAccCloudflareAccessApplication_WithSAMLSaas (3.80s)
=== RUN TestAccCloudflareAccessApplication_WithSAMLSaas_Import
=== PAUSE TestAccCloudflareAccessApplication_WithSAMLSaas_Import
=== CONT TestAccCloudflareAccessApplication_WithSAMLSaas_Import
resource_cloudflare_access_application_test.go:241: Step 1/2 error: Error running apply: exit status 1
Error: error creating Access Application for accounts "f037e56e89293a057740de681ac9abbe": error from makeRequest: access.api.error.invalid_request: saml_attribute_transform_jsonata jsonata expression is invalid (12130)
with cloudflare_access_application.dzfcrwdsqd,
on terraform_plugin_test.tf line 12, in resource "cloudflare_access_application" "dzfcrwdsqd":
12: resource "cloudflare_access_application" "dzfcrwdsqd" {
--- FAIL: TestAccCloudflareAccessApplication_WithSAMLSaas_Import (3.50s)
FAIL
FAIL github.com/cloudflare/terraform-provider-cloudflare/internal/sdkv2provider 8.441s
FAIL
make: *** [testacc] Error 1
acceptance tests all passing
|
This functionality has been released in v4.28.0 of the Terraform Cloudflare Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
No description provided.