Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DLP-1223: Add DLP dataset support #3135

Merged
merged 3 commits into from
Mar 4, 2024

Conversation

rishabh-bector
Copy link
Contributor

No description provided.

Copy link
Contributor

changelog detected ✅

@jacobbednarz
Copy link
Member

thanks for the PR but due the number of known internal issues with terraform-plugin-sdkv2 (most notably handling of zero values), we are no longer recommending using it and instead, advise using terraform-plugin-framework exclusively for all future data sources and resources. can you port this over please?

@rishabh-bector
Copy link
Contributor Author

Sure, where should the new data source live? A directory under https://github.com/cloudflare/terraform-provider-cloudflare/tree/master/internal/framework/service?

@jacobbednarz
Copy link
Member

yep! some prior art - #2961

.changelog/3135.txt Outdated Show resolved Hide resolved
@rishabh-bector rishabh-bector force-pushed the rishabh/DLP-1223 branch 3 times, most recently from e74f6a1 to 0fb4edf Compare March 1, 2024 19:36
@jacobbednarz
Copy link
Member

acceptance tests all looking good now after taking into account empty datasets.

TF_ACC=1 go test ./internal/framework/service/dlp_datasets -v -run "^TestAccCloudflareDLPDatasets_" -count 1 -timeout 120m -parallel 1
=== RUN   TestAccCloudflareDLPDatasets_DataSource
=== PAUSE TestAccCloudflareDLPDatasets_DataSource
=== CONT  TestAccCloudflareDLPDatasets_DataSource
--- PASS: TestAccCloudflareDLPDatasets_DataSource (6.41s)
PASS
ok  	github.com/cloudflare/terraform-provider-cloudflare/internal/framework/service/dlp_datasets	7.369s

@jacobbednarz jacobbednarz merged commit 12ce548 into cloudflare:master Mar 4, 2024
9 checks passed
@github-actions github-actions bot added this to the v4.26.0 milestone Mar 4, 2024
github-actions bot pushed a commit that referenced this pull request Mar 4, 2024
Copy link
Contributor

github-actions bot commented Mar 6, 2024

This functionality has been released in v4.26.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants