Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGS-351: Use DLP entry names as the set key #3090

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

OrionNebula
Copy link

@OrionNebula OrionNebula commented Jan 30, 2024

Added a custom hash function to the entries set on the cloudflare_dlp_profile resource, which should give entries stable identifiers and prevent spurious plans. Updated acceptance test to check for spurious plans.

Copy link
Contributor

changelog detected ✅

@jacobbednarz
Copy link
Member

acceptance tests look good, thanks @OrionNebula

TF_ACC=1 go test ./internal/sdkv2provider -v -run "^TestAccCloudflareDLPProfile_" -count 1 -timeout 120m -parallel 1
=== RUN   TestAccCloudflareDLPProfile_Custom
--- PASS: TestAccCloudflareDLPProfile_Custom (8.01s)
=== RUN   TestAccCloudflareDLPProfile_Custom_MultipleEntries
--- PASS: TestAccCloudflareDLPProfile_Custom_MultipleEntries (7.76s)
=== RUN   TestAccCloudflareDLPProfile_CustomWithAllowedMatchCount
--- PASS: TestAccCloudflareDLPProfile_CustomWithAllowedMatchCount (8.01s)
PASS
ok  	github.com/cloudflare/terraform-provider-cloudflare/internal/sdkv2provider	24.240s

@jacobbednarz jacobbednarz merged commit 0c17b9d into cloudflare:master Feb 1, 2024
10 checks passed
@github-actions github-actions bot added this to the v4.24.0 milestone Feb 1, 2024
github-actions bot pushed a commit that referenced this pull request Feb 1, 2024
Copy link
Contributor

github-actions bot commented Feb 7, 2024

This functionality has been released in v4.24.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 7, 2024
@OrionNebula OrionNebula deleted the otrewin/BUGS-351 branch February 9, 2024 17:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants