Support 0.12 #309
Merged
Support 0.12 #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Using the following example setup, this branch is working as expected. provider "cloudflare" {
email = "${var.cloudflare_email}"
token = "${var.cloudflare_token}"
org_id = "${var.org_id}"
}
resource "cloudflare_record" "foobar" {
domain = "${var.cloudflare_domain}"
name = "test"
value = "example.com"
type = "CNAME"
ttl = 120
} |
|
This really isn't ready for review just yet but when things are in "draft", the branch isn't visible to external systems so things like CI aren't triggered. |
Terraform 0.12 requires that resource names don't start with a number
(although they can still contain a number). To ensure we use a
consistent supported format, I've introduced
`generateRandomResourceName` which will be available to all tests for
use whenever a random resource name is required.
Fixes the following CI exception.
```
------- Stdout: -------
=== RUN TestAccCloudflareLoadBalancerPool_CreateAfterManualDestroy
=== PAUSE TestAccCloudflareLoadBalancerPool_CreateAfterManualDestroy
=== CONT TestAccCloudflareLoadBalancerPool_CreateAfterManualDestroy
--- FAIL: TestAccCloudflareLoadBalancerPool_CreateAfterManualDestroy (0.00s)
testing.go:568: Step 0 error: /opt/teamcity-agent/temp/buildTmp/tf-test154368520/main.tf:2,42-54: Invalid resource name; A name must start with a letter and may contain only letters, digits, underscores, and dashes.
FAIL
```
|
Integration tests for CI are all green with the exception of those three flakey ones which need the sweeper (addressed in #321). |
|
v0.12 went live like an hour ago. go go go! 😉 Anything I can do to help? |
|
Release to be cut in next couple of days once the dust has settled for the Hashicorp folks. In the meantime, feel free to build against |
|
@jacobbednarz how i can build and use ? |
|
Please see the building the provider section of the README. |
|
1.15.0 was released today with 0.12 compatibility. |
boekkooi-lengoo
pushed a commit
to boekkooi-lengoo/terraform-provider-cloudflare
that referenced
this pull request
Feb 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Puts all the building blocks in place for adding 0.12 support.