Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cloudflare_device_settings_policy.auto_connect is in seconds #3080

Merged
merged 2 commits into from
Jan 29, 2024

Conversation

klyubin
Copy link
Contributor

@klyubin klyubin commented Jan 26, 2024

This fixes a bug in documentation. Specifically, the documentation states that cloudflare_device_settings_policy.auto_connect is in minutes. In reality though, that field is in seconds. This commit adjusts the documentation accordingly.

@klyubin klyubin requested a review from jacobbednarz as a code owner January 26, 2024 03:35
Copy link
Contributor

github-actions bot commented Jan 26, 2024

changelog detected ✅

This fixes a bug in documentation. Specifically, the documentation
states that cloudflare_device_settings_policy.auto_connect is in
minutes. In reality though, that field is in seconds. This commit
adjusts the documentation accordingly.
@klyubin klyubin force-pushed the fix-auto_connect-docs branch from a9a5fc3 to b25e31f Compare January 26, 2024 03:38
@jacobbednarz
Copy link
Member

thanks for the PR! unfortunately, the file you've edited is a generated artifact of the documentation process. to see how to make changes to the documentation, you're best to check out https://github.com/cloudflare/terraform-provider-cloudflare/blob/master/contributing/registry-documentation.md

This means the source of truth for this change is in
`internal/sdkv2provider/schema_cloudflare_device_settings_policy.go`.
@jacobbednarz
Copy link
Member

@TylerStanish could you confirm the change here is correct?

@TylerStanish
Copy link
Contributor

That is correct, it should be seconds

@jacobbednarz jacobbednarz merged commit 3ac67ca into cloudflare:master Jan 29, 2024
8 checks passed
@jacobbednarz
Copy link
Member

thanks for confirming @TylerStanish 👏

@github-actions github-actions bot added this to the v4.24.0 milestone Jan 29, 2024
github-actions bot pushed a commit that referenced this pull request Jan 29, 2024
Copy link
Contributor

github-actions bot commented Feb 7, 2024

This functionality has been released in v4.24.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants