Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added support for teams rules notification settings #3021

Merged
merged 3 commits into from
Dec 21, 2023
Merged

feat: added support for teams rules notification settings #3021

merged 3 commits into from
Dec 21, 2023

Conversation

rexscaria
Copy link
Contributor

No description provided.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 20, 2023 •
edited
Loading

changelog detected ✅

@rexscaria rexscaria force-pushed the rex/teams_rules_notification_update branch from 0998102 to 13546d8 Compare December 20, 2023 17:06
@jacobbednarz
Copy link
Member

acceptance tests all passing

TF_ACC=1 go test ./internal/sdkv2provider -v -run "^TestAccCloudflareTeamsRule_" -count 1 -timeout 120m -parallel 1
=== RUN   TestAccCloudflareTeamsRule_Basic
--- PASS: TestAccCloudflareTeamsRule_Basic (7.98s)
=== RUN   TestAccCloudflareTeamsRule_NoSettings
--- PASS: TestAccCloudflareTeamsRule_NoSettings (12.14s)
PASS
ok  	github.com/cloudflare/terraform-provider-cloudflare/internal/sdkv2provider	20.538s

@jacobbednarz jacobbednarz merged commit 25c4749 into cloudflare:master Dec 21, 2023
9 checks passed
@github-actions github-actions bot added this to the v4.21.0 milestone Dec 21, 2023
github-actions bot pushed a commit that referenced this pull request Dec 21, 2023
Update CHANGELOG.md for #3021
f2b2af5
@github-actions GitHub Actions
Copy link
Contributor

This functionality has been released in v4.21.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jacobbednarz jacobbednarz Awaiting requested review from jacobbednarz jacobbednarz is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v4.21.0
Development

Successfully merging this pull request may close these issues.
2 participants
@rexscaria @jacobbednarz