Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add casb_findings to allowed list of logpush datasets #2859

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

webbgeorge
Copy link
Contributor

The casb_findings logpush dataset is not currently supported by the cloudflare_logpush_job resource. This PR adds support for this dataset type.

The console support this, and I have also tested with the /client/v4/accounts/{account_identifier}/logpush/jobs endpoint to double check the API supports this

Docs about this logpush dataset can be found here: https://developers.cloudflare.com/logs/reference/log-fields/account/casb_findings/

I have not raised an issue for this, as it seems fairly minor - happy to do so if requested.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 18, 2023

changelog detected ✅

@webbgeorge webbgeorge force-pushed the casb-findings-logpush branch from a100ffb to c390622 Compare October 18, 2023 10:12
@webbgeorge webbgeorge marked this pull request as ready for review October 18, 2023 10:14
@jacobbednarz
Copy link
Member

LGTM, thanks!

@jacobbednarz jacobbednarz merged commit 78da2bc into cloudflare:master Oct 19, 2023
10 checks passed
@github-actions github-actions bot added this to the v4.18.0 milestone Oct 19, 2023
github-actions bot pushed a commit that referenced this pull request Oct 19, 2023
@webbgeorge webbgeorge deleted the casb-findings-logpush branch October 19, 2023 08:56
Copy link
Contributor

This functionality has been released in v4.18.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants