Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/cloudflare_api_shield_operation: add API Shield Operation resource #2760

Merged
merged 6 commits into from
Oct 3, 2023
Merged

resource/cloudflare_api_shield_operation: add API Shield Operation resource #2760

merged 6 commits into from
Oct 3, 2023

Conversation

djhworld
Copy link
Contributor

Cloudflare-Go has been updated to include support for some endpoints in API Shield Endpoint Management.

This PR updates the terraform provider to support managing operations in API Shield Endpoint Management

Depends on cloudflare/cloudflare-go#1397

@github-actions
Copy link
Contributor

changelog detected ✅

@jacobbednarz jacobbednarz added the workflow/pending-upstream-library Indicates an issue or PR requires changes from an upstream library. label Sep 15, 2023
@djhworld djhworld force-pushed the dharper/APISHI-2354 branch 2 times, most recently from eda2f6f to 2948dbc Compare September 19, 2023 16:28
@djhworld djhworld force-pushed the dharper/APISHI-2354 branch from 2948dbc to ebcb42f Compare October 2, 2023 08:55
@djhworld djhworld marked this pull request as ready for review October 2, 2023 09:09
@djhworld djhworld requested a review from jacobbednarz as a code owner October 2, 2023 09:09
@djhworld
Copy link
Contributor Author

djhworld commented Oct 2, 2023

[email protected] was merged recently, this PR is now ready for review.

jacobbednarz
jacobbednarz reviewed Oct 3, 2023
View reviewed changes
.changelog/2760.txt Outdated Show resolved Hide resolved
@jacobbednarz
Copy link
Member

acceptance tests all look good

TF_ACC=1 go test ./internal/sdkv2provider -v -run "^TestAccCloudflareAPIShieldOperation_" -count 1 -timeout 120m -parallel 1
=== RUN   TestAccCloudflareAPIShieldOperation_Create
--- PASS: TestAccCloudflareAPIShieldOperation_Create (7.77s)
=== RUN   TestAccCloudflareAPIShieldOperation_ForceNew
--- PASS: TestAccCloudflareAPIShieldOperation_ForceNew (13.18s)
PASS
ok  	github.com/cloudflare/terraform-provider-cloudflare/internal/sdkv2provider	21.905s

@jacobbednarz jacobbednarz removed the workflow/pending-upstream-library Indicates an issue or PR requires changes from an upstream library. label Oct 3, 2023
@jacobbednarz jacobbednarz merged commit a7ce180 into cloudflare:master Oct 3, 2023
8 checks passed
@github-actions github-actions bot added this to the v4.16.0 milestone Oct 3, 2023
github-actions bot pushed a commit that referenced this pull request Oct 3, 2023
Update CHANGELOG.md for #2760
6c9164e
@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2023

This functionality has been released in v4.16.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jacobbednarz jacobbednarz jacobbednarz left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v4.16.0
Development

Successfully merging this pull request may close these issues.
2 participants
@djhworld @jacobbednarz