Add R2 scopes for api_token_permission_groups #2687
Conversation
|
changelog detected ✅ |
|
Marking as draft because I'm getting a weird issue of import cycle with root@de78b1a86397:/workspaces/terraform-provider-cloudflare# TF_ACC=1 go test ./internal/framework/service/api_token_permissions_groups -v -count 1 -run ^TestAccCloudflareApiTokenPermissio
nGroups_Basic -timeout 120m -parallel 1
# github.com/cloudflare/terraform-provider-cloudflare/internal/framework/service/api_token_permissions_groups
package github.com/cloudflare/terraform-provider-cloudflare/internal/framework/service/api_token_permissions_groups
imports github.com/cloudflare/terraform-provider-cloudflare/internal/framework/provider
imports github.com/cloudflare/terraform-provider-cloudflare/internal/acctest: import cycle not allowed in test
FAIL github.com/cloudflare/terraform-provider-cloudflare/internal/framework/service/api_token_permissions_groups [setup failed]Not entirely sure why that is because the rulesets resource_test has the same imports |
internal/framework/service/api_token_permissions_groups/data_source_test.go
Outdated
Show resolved
Hide resolved
|
this is a great initiative but i'm also happy if you just do this in the SDKv2 instead. we don't need to solve all of this at once :) |
| func stringListChecksum(s []string) string { | ||
| sort.Strings(s) | ||
| return stringChecksum(strings.Join(s, "")) | ||
| } | ||
|
|
||
| // stringChecksum takes a string and returns the checksum of the string. | ||
| func stringChecksum(s string) string { | ||
| h := md5.New() | ||
| h.Write([]byte(s)) | ||
| bs := h.Sum(nil) | ||
|
|
||
| return fmt.Sprintf("%x", bs) | ||
| } |
There was a problem hiding this comment.
This should probably be moved somewhere else, but not sure where the best place would be.
|
I've removed the docs changes that aren't related to this change to prevent merge issues. |
|
acceptance tests all passing |
|
This functionality has been released in v4.13.0 of the Terraform Cloudflare Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
Adds support for new R2 permission scopes. Also converts to the plugin framework
Closes #2684