Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add web analytics site and rule #2686

Merged
merged 9 commits into from
Aug 29, 2023

Conversation

broswen
Copy link
Contributor

@broswen broswen commented Aug 16, 2023

Adds web analytics site and rule resources.
Depends on: cloudflare/cloudflare-go#1348
Public API docs: https://developers.cloudflare.com/api/operations/web-analytics-create-site
CC @cf-ypark

@broswen broswen requested a review from jacobbednarz as a code owner August 16, 2023 00:08
@github-actions
Copy link
Contributor

changelog detected ✅

@broswen broswen force-pushed the bswenson/web-analytics branch from b6084cb to 32733b4 Compare August 28, 2023 20:10
@jacobbednarz
Copy link
Member

just chasing down one last failing test case (on destroy)

TF_ACC=1 go test ./internal/sdkv2provider -v -run "^TestAccCloudflareWebAnalyticsRule_" -count 1 -timeout 120m -parallel 1
=== RUN   TestAccCloudflareWebAnalyticsRule_Create
=== PAUSE TestAccCloudflareWebAnalyticsRule_Create
=== CONT  TestAccCloudflareWebAnalyticsRule_Create
    testing_new.go:88: Error running post-test destroy, there may be dangling resources: failed to fetch web analytics rules: web_analytics.configuration.api.malformedParams (10004)
--- FAIL: TestAccCloudflareWebAnalyticsRule_Create (16.45s)
FAIL
FAIL	github.com/cloudflare/terraform-provider-cloudflare/internal/sdkv2provider	17.767s
FAIL
make: *** [testacc] Error 1

@jacobbednarz jacobbednarz force-pushed the bswenson/web-analytics branch from 290998d to 38a123d Compare August 28, 2023 22:54
@jacobbednarz
Copy link
Member

thanks @broswen 👏 acceptance tests all looking good now

TF_ACC=1 go test ./internal/sdkv2provider -v -run "^(TestAccCloudflareWebAnalyticsRule_|TestAccCloudflareWebAnalyticsSite_)" -count 1 -timeout 120m -parallel 1
=== RUN   TestAccCloudflareWebAnalyticsRule_Create
=== PAUSE TestAccCloudflareWebAnalyticsRule_Create
=== RUN   TestAccCloudflareWebAnalyticsSite_Create
=== PAUSE TestAccCloudflareWebAnalyticsSite_Create
=== CONT  TestAccCloudflareWebAnalyticsRule_Create
--- PASS: TestAccCloudflareWebAnalyticsRule_Create (15.32s)
=== CONT  TestAccCloudflareWebAnalyticsSite_Create
--- PASS: TestAccCloudflareWebAnalyticsSite_Create (13.07s)
PASS
ok  	github.com/cloudflare/terraform-provider-cloudflare/internal/sdkv2provider	28.869s

Signed-off-by: Jacob Bednarz <[email protected]>
@jacobbednarz jacobbednarz merged commit ebad27f into cloudflare:master Aug 29, 2023
@github-actions github-actions bot added this to the v4.14.0 milestone Aug 29, 2023
github-actions bot pushed a commit that referenced this pull request Aug 29, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

This functionality has been released in v4.14.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants