Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Regional Tiered Cache resource #2624

Merged
merged 8 commits into from
Jul 21, 2023
Merged

Add Regional Tiered Cache resource #2624

merged 8 commits into from
Jul 21, 2023

Conversation

joshuamsager
Copy link
Contributor

@joshuamsager joshuamsager commented Jul 20, 2023

Depends on https://github.com/cloudflare/cloudflare-go/tree/v0.73.0

Resolves: #2615

Implements the following terraform resource:

resource "cloudflare_regional_tiered_cache" "settings" {
  zone_id                      = "my_zone_id"
  value                        = "on"
}

Open to changing the name of the resource/schema -- or if this should be part of another existing resource, instead of an isolated one, I can move this implementation somewhere else..

TODO:

  • Generate documentation with make docs. Couldn't do this because of pending errors when resolving the cloudflare-go API version upgrade.

@github-actions
Copy link
Contributor

This project handles dependency version bumps (including upstream changes from cloudflare-go) independently of the standard PR process using automation. This allows the dependency upgrades to land without causing merge conflicts in multiple branches and handled in a consistent way. The exception to this is security related dependency upgrades but they should be co-ordinated with the maintainer team privately.

Please remove the changes to the go.mod or go.sum files from this PR in order to proceed with review and merging.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 20, 2023

changelog detected ✅

Copy link
Member

@jacobbednarz jacobbednarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

notes in automation

@jacobbednarz
Copy link
Member

jacobbednarz commented Jul 21, 2023

acceptance tests are passing

TF_ACC=1 go test ./internal/sdkv2provider -v -run "^TestAccCloudflareRegionalTieredCache_Basic" -count 1 -timeout 120m -parallel 1

=== RUN   TestAccCloudflareRegionalTieredCache_Basic
=== PAUSE TestAccCloudflareRegionalTieredCache_Basic
=== CONT  TestAccCloudflareRegionalTieredCache_Basic
--- PASS: TestAccCloudflareRegionalTieredCache_Basic (8.91s)
PASS
ok  	github.com/cloudflare/terraform-provider-cloudflare/internal/sdkv2provider	9.837s

@jacobbednarz
Copy link
Member

  • Generate documentation with make docs. Couldn't do this because of pending errors when resolving the cloudflare-go API version upgrade.

for future, you can work around this by running the following (and having cloudflare-go locally)

go mod edit -replace github.com/cloudflare/cloudflare-go=/path/to/cloudflare-go/locally

allows you to test without waiting for a full release :)

@jacobbednarz jacobbednarz merged commit d1c7f36 into cloudflare:master Jul 21, 2023
@github-actions github-actions bot added this to the v4.11.0 milestone Jul 21, 2023
@jacobbednarz
Copy link
Member

thanks for these PRs @joshuamsager, it's appreciated!

github-actions bot pushed a commit that referenced this pull request Jul 21, 2023
@joshuamsager joshuamsager deleted the joshuamsager/add-regional-tiered-cache-resource branch July 24, 2023 15:40
@github-actions
Copy link
Contributor

This functionality has been released in v4.11.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for regional tiered caching
2 participants