Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/cloudflare_waiting_room: Add cookie_suffix & additional_routes to the WR resource #2528

Merged
merged 8 commits into from
Jun 26, 2023
Merged

resource/cloudflare_waiting_room: Add cookie_suffix & additional_routes to the WR resource #2528

merged 8 commits into from
Jun 26, 2023

Conversation

yj7o5
Copy link
Contributor

@yj7o5 yj7o5 commented Jun 14, 2023

Add new fields additional_routes and cookie_suffix to the Waiting Room resource.

@yj7o5 yj7o5 requested a review from jacobbednarz as a code owner June 14, 2023 21:31
@github-actions
Copy link
Contributor

github-actions bot commented Jun 14, 2023 •
edited
Loading

changelog detected ✅

@yj7o5
Copy link
Contributor Author

yj7o5 commented Jun 15, 2023 •
edited
Loading

Waiting on this cloudflare/cloudflare-go#1311 to get the WR schema definition to be updated to get the unit tests passing.

@jacobbednarz jacobbednarz added the workflow/pending-upstream-library Indicates an issue or PR requires changes from an upstream library. label Jun 16, 2023
@jacobbednarz
Copy link
Member

please remove the version bump from this PR; we have automation that handles that and avoids per branch conflicts.

@jacobbednarz jacobbednarz force-pushed the wr-additional-routes branch from c4c6041 to fb3b886 Compare June 25, 2023 23:52
@jacobbednarz
Copy link
Member

acceptance tests all passing

TF_ACC=1 go test ./internal/sdkv2provider -v -run "^TestAccCloudflareWaitingRoom_" -count 1 -timeout 120m -parallel 1
=== RUN   TestAccCloudflareWaitingRoom_Create
=== PAUSE TestAccCloudflareWaitingRoom_Create
=== CONT  TestAccCloudflareWaitingRoom_Create
--- PASS: TestAccCloudflareWaitingRoom_Create (6.43s)
PASS
ok  	github.com/cloudflare/terraform-provider-cloudflare/internal/sdkv2provider	7.333s

@jacobbednarz jacobbednarz removed the workflow/pending-upstream-library Indicates an issue or PR requires changes from an upstream library. label Jun 25, 2023
@jacobbednarz jacobbednarz force-pushed the wr-additional-routes branch from fb3b886 to 9342f71 Compare June 25, 2023 23:58
@jacobbednarz
Copy link
Member

thanks for the PR @yj7o5 🤘 you rock.

@jacobbednarz jacobbednarz merged commit ed8e3af into cloudflare:master Jun 26, 2023
@github-actions github-actions bot added this to the v4.9.0 milestone Jun 26, 2023
github-actions bot pushed a commit that referenced this pull request Jun 26, 2023
Update CHANGELOG.md for #2528
528e5c7
@github-actions
Copy link
Contributor

This functionality has been released in v4.9.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jacobbednarz jacobbednarz Awaiting requested review from jacobbednarz jacobbednarz is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v4.9.0
Development

Successfully merging this pull request may close these issues.
2 participants
@yj7o5 @jacobbednarz