Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

load_balancing: support header session affinity policy #2521

Merged

Conversation

ColeBennett
Copy link

@ColeBennett ColeBennett commented Jun 13, 2023

Adds support for the new header session affinity policy and its related session affinity attribute.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 13, 2023

changelog detected ✅

@ColeBennett ColeBennett force-pushed the cbennett/lb-header-session-affinity branch 3 times, most recently from faa0451 to 86f59c8 Compare June 13, 2023 22:10
@ColeBennett ColeBennett force-pushed the cbennett/lb-header-session-affinity branch 3 times, most recently from 280639e to c0b4992 Compare July 5, 2023 22:18
@ColeBennett ColeBennett force-pushed the cbennett/lb-header-session-affinity branch from c0b4992 to c01a207 Compare July 21, 2023 20:09
@ColeBennett ColeBennett marked this pull request as ready for review July 21, 2023 20:09
@ColeBennett ColeBennett force-pushed the cbennett/lb-header-session-affinity branch 3 times, most recently from c827bfd to 4636a24 Compare July 24, 2023 22:27
@ColeBennett ColeBennett force-pushed the cbennett/lb-header-session-affinity branch from 4636a24 to 05d29a4 Compare July 24, 2023 22:34
@ColeBennett
Copy link
Author

Hi @jacobbednarz, this is ready for review

@jacobbednarz
Copy link
Member

acceptance tests all passing

TF_ACC=1 go test ./internal/sdkv2provider -v -run "^TestAccCloudflareLoadBalancer_" -count 1 -timeout 120m -parallel 1
=== RUN   TestAccCloudflareLoadBalancer_Import
=== PAUSE TestAccCloudflareLoadBalancer_Import
=== RUN   TestAccCloudflareLoadBalancer_Basic
--- PASS: TestAccCloudflareLoadBalancer_Basic (5.34s)
=== RUN   TestAccCloudflareLoadBalancer_SessionAffinity
--- PASS: TestAccCloudflareLoadBalancer_SessionAffinity (4.84s)
=== RUN   TestAccCloudflareLoadBalancer_SessionAffinityIPCookie
--- PASS: TestAccCloudflareLoadBalancer_SessionAffinityIPCookie (5.16s)
=== RUN   TestAccCloudflareLoadBalancer_SessionAffinityHeader
--- PASS: TestAccCloudflareLoadBalancer_SessionAffinityHeader (5.57s)
=== RUN   TestAccCloudflareLoadBalancer_AdaptiveRouting
--- PASS: TestAccCloudflareLoadBalancer_AdaptiveRouting (5.16s)
=== RUN   TestAccCloudflareLoadBalancer_LocationStrategy
--- PASS: TestAccCloudflareLoadBalancer_LocationStrategy (5.17s)
=== RUN   TestAccCloudflareLoadBalancer_RandomSteering
--- PASS: TestAccCloudflareLoadBalancer_RandomSteering (8.56s)
=== RUN   TestAccCloudflareLoadBalancer_GeoBalanced
--- PASS: TestAccCloudflareLoadBalancer_GeoBalanced (5.26s)
=== RUN   TestAccCloudflareLoadBalancer_ProximityBalanced
--- PASS: TestAccCloudflareLoadBalancer_ProximityBalanced (5.06s)
=== RUN   TestAccCloudflareLoadBalancer_LeastOutstandingRequestsBalanced
--- PASS: TestAccCloudflareLoadBalancer_LeastOutstandingRequestsBalanced (5.05s)
=== RUN   TestAccCloudflareLoadBalancer_Rules
--- PASS: TestAccCloudflareLoadBalancer_Rules (5.31s)
=== RUN   TestAccCloudflareLoadBalancer_DuplicatePool
--- PASS: TestAccCloudflareLoadBalancer_DuplicatePool (2.25s)
=== RUN   TestAccCloudflareLoadBalancer_Update
--- PASS: TestAccCloudflareLoadBalancer_Update (8.79s)
=== RUN   TestAccCloudflareLoadBalancer_CreateAfterManualDestroy
--- PASS: TestAccCloudflareLoadBalancer_CreateAfterManualDestroy (8.55s)
=== CONT  TestAccCloudflareLoadBalancer_Import
--- PASS: TestAccCloudflareLoadBalancer_Import (6.04s)
PASS
ok  	github.com/cloudflare/terraform-provider-cloudflare/internal/sdkv2provider	86.666s

@jacobbednarz jacobbednarz merged commit abecfe1 into cloudflare:master Jul 25, 2023
@github-actions github-actions bot added this to the v4.11.0 milestone Jul 25, 2023
github-actions bot pushed a commit that referenced this pull request Jul 25, 2023
@github-actions
Copy link
Contributor

This functionality has been released in v4.11.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants