Adds additional validation for TTLs for cloudflare_ruleset action_parameters #2454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
changelog detected ✅ |
|
at a high level, this looks fine. let's add some test coverage to ensure that these validators are covered. an acceptance test is likely the easiest to interface with. |
iveelsm
force-pushed
the
master
branch
2 times, most recently
from
a3db872 to
4bc5a9d
Compare
…ameters This adds new validation for the schema that enforces TTL values for specific modes within the cloudflare_ruleset action parameters. This applies to the browser_ttl and edge_ttl blocks within the action_parameters schema. The validation will serialize the existing values into a type that is a 1:1 match of the schema and then will determine if the default value for the ttl is greater than zero for the configured rule. Implementation: * Custom object validator for Browser TTL block within action_parameters for cloudflare_ruleset * Custom object validator for Edge TTL block within action_parameters for cloudflare_ruleset
|
This functionality has been released in v4.7.0 of the Terraform Cloudflare Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds new validation for the schema that enforces TTL values for specific modes within the cloudflare_ruleset action parameters. This applies to the browser_ttl and edge_ttl blocks within the action_parameters schema. The validation will serialize the existing values into a type that is a 1:1 match of the schema and then will determine if the default value for the ttl is greater than zero for the configured rule.
Implementation: