Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add drop options to email_routing_rule #2449

Merged
merged 6 commits into from
Nov 23, 2023
Merged

add drop options to email_routing_rule #2449

merged 6 commits into from
Nov 23, 2023

Conversation

limejuny
Copy link
Contributor

Detail

@limejuny limejuny requested a review from jacobbednarz as a code owner May 18, 2023 04:02
@github-actions
Copy link
Contributor

github-actions bot commented May 18, 2023 •
edited
Loading

changelog detected ✅

@jacobbednarz jacobbednarz added the workflow/pending-public-documentation Indicates an issue or PR requires changes to public documentation confirming suitability for use. label May 18, 2023
@mircea-pavel-anton

This comment was marked as off-topic.

Sign in to view
@limejuny
add drop options to email_routing_rule
4c91c1d 
Detail
======
 - the `action` should be one of `forward`, `worker`, `drop`, but there
   was no `drop` in latest provider.
 - ref: cloudflare#1947
@limejuny
add action type drop to email routing rule
85e4e22
@limejuny limejuny force-pushed the feature/email-routing-drop branch from cd295ed to 85e4e22 Compare November 21, 2023 14:20
@limejuny
Copy link
Contributor Author

The public documents also has drop options. (link)

@jacobbednarz
Copy link
Member

acceptance tests all passing

TF_ACC=1 go test ./internal/sdkv2provider -v -run "^TestAccCloudflareEmailRoutingRule_" -count 1 -timeout 120m -parallel 1
=== RUN   TestAccCloudflareEmailRoutingRule_Basic
--- PASS: TestAccCloudflareEmailRoutingRule_Basic (10.85s)
=== RUN   TestAccCloudflareEmailRoutingRule_Drop
--- PASS: TestAccCloudflareEmailRoutingRule_Drop (9.63s)
PASS
ok  	github.com/cloudflare/terraform-provider-cloudflare/internal/sdkv2provider	21.366s

@jacobbednarz jacobbednarz merged commit f463384 into cloudflare:master Nov 23, 2023
9 checks passed
@github-actions github-actions bot added this to the v4.20.0 milestone Nov 23, 2023
github-actions bot pushed a commit that referenced this pull request Nov 23, 2023
Update CHANGELOG.md for #2449
89413c0
@github-actions GitHub Actions
Copy link
Contributor

This functionality has been released in v4.20.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jacobbednarz jacobbednarz jacobbednarz left review comments

Assignees
No one assigned
Labels
workflow/pending-public-documentation Indicates an issue or PR requires changes to public documentation confirming suitability for use.
Projects
None yet
Milestone
v4.20.0
Development

Successfully merging this pull request may close these issues.

Cannot specify type = drop for cloudflare_email_routing_rule
3 participants
@limejuny @mircea-pavel-anton @jacobbednarz