Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issues with turnstile widget resource #2413

Merged
merged 3 commits into from
May 8, 2023
Merged

Fix issues with turnstile widget resource #2413

merged 3 commits into from
May 8, 2023

Conversation

Cyb3r-Jak3
Copy link
Contributor

Adds region and bot fight mode to be computed with a new unit test to check
Fix issue where widget could not be updated

Fixes #2412

@Cyb3r-Jak3 Cyb3r-Jak3 requested a review from jacobbednarz as a code owner May 6, 2023 18:12
@Cyb3r-Jak3
Copy link
Contributor Author

@punkeel

@github-actions
Copy link
Contributor

github-actions bot commented May 6, 2023

changelog detected ✅

punkeel
punkeel approved these changes May 6, 2023
View reviewed changes
Copy link
Member

@punkeel punkeel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank-you-sticker-thanks-sticker

This was referenced May 6, 2023
Closed
Merged
@jacobbednarz
Copy link
Member

acceptance tests look good!

TF_ACC=1 go test ./internal/framework/service/turnstile -v -count 1 -run ^TestAccCloudflareTurnstileWidget_ -timeout 120m -parallel 1
=== RUN   TestAccCloudflareTurnstileWidget_Basic
=== PAUSE TestAccCloudflareTurnstileWidget_Basic
=== RUN   TestAccCloudflareTurnstileWidget_Minimum
=== PAUSE TestAccCloudflareTurnstileWidget_Minimum
=== CONT  TestAccCloudflareTurnstileWidget_Basic
--- PASS: TestAccCloudflareTurnstileWidget_Basic (17.09s)
=== CONT  TestAccCloudflareTurnstileWidget_Minimum
--- PASS: TestAccCloudflareTurnstileWidget_Minimum (17.90s)
PASS
ok  	github.com/cloudflare/terraform-provider-cloudflare/internal/framework/service/turnstile	35.955s

thanks for the speedy turn around on this one 🙇

@jacobbednarz jacobbednarz merged commit d815d63 into cloudflare:master May 8, 2023
@github-actions github-actions bot added this to the v4.6.0 milestone May 8, 2023
github-actions bot pushed a commit that referenced this pull request May 8, 2023
Update CHANGELOG.md for #2413
fa2225b
@Cyb3r-Jak3 Cyb3r-Jak3 deleted the fix-turnstile-schema branch May 8, 2023 00:51
This was referenced May 8, 2023
Closed
Closed
@LinusU LinusU mentioned this pull request May 10, 2023
Merged
@github-actions
Copy link
Contributor

This functionality has been released in v4.6.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@punkeel punkeel punkeel approved these changes

@jacobbednarz jacobbednarz Awaiting requested review from jacobbednarz jacobbednarz is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v4.6.0
Development

Successfully merging this pull request may close these issues.

Turnstile doesn't handle optional values properly
3 participants
@Cyb3r-Jak3 @jacobbednarz @punkeel