Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation for cloudflare_access_group resource #2332

Merged
merged 3 commits into from
Mar 30, 2023

Conversation

Nmishin
Copy link
Contributor

@Nmishin Nmishin commented Mar 27, 2023

Closes #2299

@Nmishin Nmishin requested a review from jacobbednarz as a code owner March 27, 2023 21:43
@github-actions
Copy link
Contributor

changelog detected ✅

@Nmishin
Copy link
Contributor Author

Nmishin commented Mar 27, 2023

this is for #2299

@@ -22,3 +22,16 @@ resource "cloudflare_access_group" "test_group" {
ip = [var.office_ip]
}
}

# Allow members of an Azure Group. The ID is the group UUID (id) in Azure:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'll 👍 this but generally, we don't have kitchen sink style examples in our Terraform documentation. this should live in our developer documentation with an overview of how to use Azure as opposed to only in our Terraform implementation.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got it, thank you

.changelog/2332.txt Outdated Show resolved Hide resolved
@jacobbednarz jacobbednarz merged commit 8eb84da into cloudflare:master Mar 30, 2023
@github-actions github-actions bot added this to the v4.3.0 milestone Mar 30, 2023
github-actions bot pushed a commit that referenced this pull request Mar 30, 2023
@Nmishin Nmishin deleted the fix/2299 branch March 30, 2023 08:05
@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2023

This functionality has been released in v4.3.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cloudflare_access_group documentation is not clear for azure
2 participants