add compatibility_flags to cloudflare_workers_script #2324

abiodunakande · 2023-03-25T08:09:37Z

Adds compatibility_flags attribute to workers script resource.

Following up on this issue here where compatibility_date was added.

github-actions · 2023-03-25T08:11:49Z

changelog detected ✅

…uotes

internal/sdkv2provider/resource_cloudflare_workers_script.go

abiodunakande · 2023-03-27T09:37:01Z

jacobbednarz · 2023-03-28T03:38:59Z

internal/sdkv2provider/schema_cloudflare_workers_script.go

@@ -159,6 +159,15 @@ func resourceCloudflareWorkerScriptSchema() map[string]*schema.Schema {
 			Optional:    true,
 			Description: "The date to use for the compatibility flag.",
 		},
+		"compatibility_flags": {
+			Type:        schema.TypeList,


given that we don't care about ordering, let's use a TypeSet here.

jacobbednarz · 2023-03-28T03:39:33Z

internal/sdkv2provider/resource_cloudflare_workers_script.go

@@ -131,6 +131,14 @@ func parseWorkerBindings(d *schema.ResourceData, bindings ScriptBindings) {
 	}
 }

+func getCompatibilityFlags(d *schema.ResourceData) []string {
+	compatibilityFlags := make([]string, 0)
+	for _, item := range d.Get("compatibility_flags").([]interface{}) {


when you swap to a TypeSet this will become

Suggested change

for _, item := range d.Get("compatibility_flags").([]interface{}) {

for _, item := range d.Get("compatibility_flags").(*schema.Set).List() {

jacobbednarz · 2023-03-28T03:40:47Z

very close to getting this sorted! for next time, if you use a non-master branch and allow maintainers to edit the PR, we'll be able to fix these sorts of things without having the back and forth :)

abiodunakande · 2023-03-28T11:38:16Z

very close to getting this sorted! for next time, if you use a non-master branch and allow maintainers to edit the PR, we'll be able to fix these sorts of things without having the back and forth :)

Good shout, will bear that in mind :) thank you

jacobbednarz · 2023-03-28T22:18:51Z

acceptance tests all passing

TF_ACC=1 go test ./internal/sdkv2provider -v -run "^TestAccCloudflareWorkerScript_" -timeout 120m -parallel 1
=== RUN   TestAccCloudflareWorkerScript_Import
--- PASS: TestAccCloudflareWorkerScript_Import (20.01s)
=== RUN   TestAccCloudflareWorkerScript_MultiScriptEnt
=== PAUSE TestAccCloudflareWorkerScript_MultiScriptEnt
=== RUN   TestAccCloudflareWorkerScript_ModuleUpload
=== PAUSE TestAccCloudflareWorkerScript_ModuleUpload
=== CONT  TestAccCloudflareWorkerScript_MultiScriptEnt
--- PASS: TestAccCloudflareWorkerScript_MultiScriptEnt (44.65s)
=== CONT  TestAccCloudflareWorkerScript_ModuleUpload
--- PASS: TestAccCloudflareWorkerScript_ModuleUpload (14.09s)
PASS
ok  	github.com/cloudflare/terraform-provider-cloudflare/internal/sdkv2provider	79.711s

github-actions · 2023-04-04T22:18:26Z

This functionality has been released in v4.3.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Add compatibility flags to workers script resource

3c80c25

abiodunakande requested a review from jacobbednarz as a code owner March 25, 2023 08:09

Updating ./changelog 2323 -> 2324

f11f563

abiodunakande mentioned this pull request Mar 25, 2023

add compatibility_flags to cloudflare_workers_script #2323

Closed

Abiodun Akande added 2 commits March 25, 2023 08:18

Update test for workers script to surround compatibility flags with q…

352c203

…uotes

Amend compatibility_flags schema description

8ffa65a

jacobbednarz reviewed Mar 27, 2023

View reviewed changes

internal/sdkv2provider/resource_cloudflare_workers_script.go Outdated Show resolved Hide resolved

jacobbednarz reviewed Mar 27, 2023

View reviewed changes

internal/sdkv2provider/resource_cloudflare_workers_script.go Outdated Show resolved Hide resolved

Abiodun Akande added 2 commits March 27, 2023 09:53

Streamline getCompatibilityFlags

3f2cf91

Fixing workers module upload with compatibility_flags that exist

fece1a9

jacobbednarz reviewed Mar 28, 2023

View reviewed changes

Change compatibility_flags Type from TypeList -> TypeSet

c1d7314

Revert manual edit of worker script doc

796cc24

jacobbednarz merged commit b9afbb5 into cloudflare:master Mar 28, 2023

github-actions bot added this to the v4.3.0 milestone Mar 28, 2023

github-actions bot pushed a commit that referenced this pull request Mar 28, 2023

Update CHANGELOG.md for #2324

9fb8773

github-actions bot locked as resolved and limited conversation to collaborators Apr 4, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add compatibility_flags to cloudflare_workers_script #2324

add compatibility_flags to cloudflare_workers_script #2324

abiodunakande commented Mar 25, 2023

github-actions bot commented Mar 25, 2023

abiodunakande commented Mar 27, 2023

jacobbednarz Mar 28, 2023

jacobbednarz Mar 28, 2023

jacobbednarz commented Mar 28, 2023

abiodunakande commented Mar 28, 2023

jacobbednarz commented Mar 28, 2023

github-actions bot commented Apr 4, 2023

	for _, item := range d.Get("compatibility_flags").([]interface{}) {
	for _, item := range d.Get("compatibility_flags").(*schema.Set).List() {

add compatibility_flags to cloudflare_workers_script #2324

add compatibility_flags to cloudflare_workers_script #2324

Conversation

abiodunakande commented Mar 25, 2023

github-actions bot commented Mar 25, 2023

abiodunakande commented Mar 27, 2023

jacobbednarz Mar 28, 2023

Choose a reason for hiding this comment

jacobbednarz Mar 28, 2023

Choose a reason for hiding this comment

jacobbednarz commented Mar 28, 2023

abiodunakande commented Mar 28, 2023

jacobbednarz commented Mar 28, 2023

github-actions bot commented Apr 4, 2023