Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cloudflare_list_item resource #2304

Merged
merged 14 commits into from
Mar 21, 2023

Conversation

rwhelan
Copy link
Contributor

@rwhelan rwhelan commented Mar 20, 2023

Continuation of #2295 without the messy rebase.

Closes #2283

@rwhelan rwhelan requested a review from jacobbednarz as a code owner March 20, 2023 15:38
@github-actions
Copy link
Contributor

github-actions bot commented Mar 20, 2023

changelog detected ✅

@jacobbednarz
Copy link
Member

acceptance tests all passing

TF_ACC=1 go test ./internal/sdkv2provider -v -run "^(TestAccCloudflareList_|TestAccCloudflareListItem_)" -timeout 120m -parallel 1
=== RUN   TestAccCloudflareListItem_Exists
--- PASS: TestAccCloudflareListItem_Exists (17.99s)
=== RUN   TestAccCloudflareListItem_Update
--- PASS: TestAccCloudflareListItem_Update (29.30s)
=== RUN   TestAccCloudflareListItem_BadListItemType
--- PASS: TestAccCloudflareListItem_BadListItemType (8.50s)
=== RUN   TestAccCloudflareList_Exists
--- PASS: TestAccCloudflareList_Exists (12.28s)
=== RUN   TestAccCloudflareList_UpdateDescription
--- PASS: TestAccCloudflareList_UpdateDescription (22.73s)
=== RUN   TestAccCloudflareList_Update
--- PASS: TestAccCloudflareList_Update (65.02s)
=== RUN   TestAccCloudflareList_UpdateIgnoreIPOrdering
--- PASS: TestAccCloudflareList_UpdateIgnoreIPOrdering (24.84s)
=== RUN   TestAccCloudflareList_RemoveInlineConfig
--- PASS: TestAccCloudflareList_RemoveInlineConfig (36.10s)
PASS
ok  	github.com/cloudflare/terraform-provider-cloudflare/internal/sdkv2provider	217.403s

thanks for this @rwhelan!

@jacobbednarz jacobbednarz merged commit 91de77a into cloudflare:master Mar 21, 2023
@github-actions github-actions bot added this to the v4.2.0 milestone Mar 21, 2023
github-actions bot pushed a commit that referenced this pull request Mar 21, 2023
@github-actions
Copy link
Contributor

This functionality has been released in v4.2.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 22, 2023
@rwhelan rwhelan deleted the resource_list_item branch March 24, 2023 15:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

List Item Resource
2 participants