Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add compatibility_date to cloudflare_workers_script #2300

Merged

Conversation

SASNOVACAT08
Copy link
Contributor

@SASNOVACAT08 SASNOVACAT08 commented Mar 19, 2023

Hello, thank you for this repo.

Currently, I deploy a worker without compatibility_date and FormData doesn't support File. I need to publish again with wrangler to have the compatibility_date.

I have added the attribute compatibility_date.

Closes #1869

@github-actions
Copy link
Contributor

github-actions bot commented Mar 19, 2023

changelog detected ✅

@SASNOVACAT08 SASNOVACAT08 force-pushed the feat/add-compatibility-date branch from cbb05d6 to faddc5b Compare March 19, 2023 20:49
@jacobbednarz
Copy link
Member

acceptance tests all lookig good! thanks @SASNOVACAT08 👏

$ TEST="./internal/sdkv2provider" TESTARGS='-run "^TestAccCloudflareWorkerScript_"' make testacc
TF_ACC=1 go test ./internal/sdkv2provider -v -run "^TestAccCloudflareWorkerScript_" -timeout 120m -parallel 1
=== RUN   TestAccCloudflareWorkerScript_Import
--- PASS: TestAccCloudflareWorkerScript_Import (20.31s)
=== RUN   TestAccCloudflareWorkerScript_MultiScriptEnt
=== PAUSE TestAccCloudflareWorkerScript_MultiScriptEnt
=== RUN   TestAccCloudflareWorkerScript_ModuleUpload
=== PAUSE TestAccCloudflareWorkerScript_ModuleUpload
=== CONT  TestAccCloudflareWorkerScript_MultiScriptEnt
--- PASS: TestAccCloudflareWorkerScript_MultiScriptEnt (47.49s)
=== CONT  TestAccCloudflareWorkerScript_ModuleUpload
--- PASS: TestAccCloudflareWorkerScript_ModuleUpload (14.22s)
PASS
ok  	github.com/cloudflare/terraform-provider-cloudflare/internal/sdkv2provider	82.896s

@jacobbednarz jacobbednarz merged commit fa0ae81 into cloudflare:master Mar 19, 2023
@github-actions github-actions bot added this to the v4.2.0 milestone Mar 19, 2023
github-actions bot pushed a commit that referenced this pull request Mar 19, 2023
rwhelan pushed a commit to rwhelan/terraform-provider-cloudflare that referenced this pull request Mar 20, 2023
@github-actions
Copy link
Contributor

This functionality has been released in v4.2.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow setting worker compatibility_date/flags
2 participants