New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Address Map resource #2290

Merged

jacobbednarz merged 7 commits into cloudflare:master from hunts:hunts/add-support-for-address-maps-apis

Mar 21, 2023

Contributor

hunts commented Mar 15, 2023

Adds support for the Proxy IPs feature, allow CRUD address maps.


          Add support for Address Map resource

b27becb

hunts requested a review from jacobbednarz as a code owner

March 15, 2023 02:10

Contributor

github-actions bot commented Mar 15, 2023 •

edited

Loading

changelog detected ✅

jacobbednarz reviewed

View reviewed changes

internal/sdkv2provider/provider.go Outdated Show resolved Hide resolved

jacobbednarz reviewed

View reviewed changes

internal/sdkv2provider/resource_cloudflare_address_map_test.go Show resolved Hide resolved

jacobbednarz reviewed

View reviewed changes

internal/sdkv2provider/schema_cloudflare_address_map.go Show resolved Hide resolved

jacobbednarz reviewed

View reviewed changes

internal/sdkv2provider/schema_cloudflare_address_map.go Outdated Show resolved Hide resolved

jacobbednarz reviewed

View reviewed changes

internal/sdkv2provider/schema_cloudflare_address_map.go Show resolved Hide resolved

jacobbednarz reviewed

View reviewed changes

docs/resources/address_map.md Show resolved Hide resolved

Member

jacobbednarz commented Mar 15, 2023

thanks for this @hunts! we're 95% of the way there. to summarise the inline comments:

we need to update all fields to have a Description field.
get the acceptance testing hooked up with the correct entitlements so we can run these tests.
add a CHANGELOG entry

after that, we should be good to go here.

hunts and others added 5 commits

March 14, 2023 21:31


          make docs for Address Map


          add missing field description in AddressMap schema

3381d61


          Add address map importer implementation

a2cbf78


          Merge branch 'master' into hunts/add-support-for-address-maps-apis

12769fa


          generalise test setup

63d6f24

Member

jacobbednarz commented Mar 21, 2023

acceptance tests all passing

TF_ACC=1 go test ./internal/sdkv2provider -v -run "^TestAccCloudflareAddressMap" -timeout 120m -parallel 1
=== RUN   TestAccCloudflareAddressMap
--- PASS: TestAccCloudflareAddressMap (37.29s)
PASS
ok  	github.com/cloudflare/terraform-provider-cloudflare/internal/sdkv2provider	38.320s


          add changelog entry

ee7bdb2

jacobbednarz merged commit 16e7517 into cloudflare:master

github-actions bot added this to the v4.2.0 milestone

github-actions bot pushed a commit that referenced this pull request


          Update CHANGELOG.md for #2290

e895743

hunts deleted the hunts/add-support-for-address-maps-apis branch

March 22, 2023 00:09

Contributor

github-actions bot commented Mar 22, 2023

This functionality has been released in v4.2.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

github-actions bot locked as resolved and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet