Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add mtls cert store support #2182

Conversation

vasilzhigilei
Copy link
Contributor

Adding Terraform support for https://api.cloudflare.com/#mtls-certificate-management-properties
Just includes the mTLS certificates which can be set by the user. mTLS associations will be added in a separate PR and are just read-only.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 24, 2023

changelog detected ✅

@vasilzhigilei vasilzhigilei force-pushed the vasil/add-mtls-certificates-cert-store-support branch from 53e83b5 to ba588ba Compare January 25, 2023 15:48
@vasilzhigilei vasilzhigilei marked this pull request as ready for review January 25, 2023 19:36
@@ -79,6 +79,17 @@ func testAccPreCheck(t *testing.T) {
}
}

func testAccPreCheckWithoutZoneID(t *testing.T) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

default testAccPreCheck checks for Zone as well, but mTLS certs are account-level.

@jacobbednarz
Copy link
Member

acceptance tests are passing

TF_ACC=1 go test $(go list ./...) -v -run "^TestAccCloudflareMTLSCertificate" -count 1 -parallel 1 -timeout 120m -parallel 1
?   	github.com/cloudflare/terraform-provider-cloudflare	[no test files]
?   	github.com/cloudflare/terraform-provider-cloudflare/internal/consts	[no test files]
?   	github.com/cloudflare/terraform-provider-cloudflare/internal/framework/modifiers/defaults	[no test files]
testing: warning: no tests to run
PASS
ok  	github.com/cloudflare/terraform-provider-cloudflare/internal/framework/provider	0.407s [no tests to run]
testing: warning: no tests to run
PASS
ok  	github.com/cloudflare/terraform-provider-cloudflare/internal/framework/service/example	0.508s [no tests to run]
=== RUN   TestAccCloudflareMTLSCertificate
--- PASS: TestAccCloudflareMTLSCertificate (11.09s)
PASS
ok  	github.com/cloudflare/terraform-provider-cloudflare/internal/sdkv2provider	11.507s
?   	github.com/cloudflare/terraform-provider-cloudflare/internal/utils	[no test files]

@jacobbednarz jacobbednarz merged commit de7da0c into cloudflare:master Jan 27, 2023
@github-actions github-actions bot added this to the v3.34.0 milestone Jan 27, 2023
github-actions bot pushed a commit that referenced this pull request Jan 27, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2023

This functionality has been released in v3.34.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants