Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add allow_insecure and follow_redirects to load balancer monitor #205

Conversation

jacobbednarz
Copy link
Member

This updates the cloudflare_load_balancer_monitor to accept two new
attributes:

  • allow_insecure: Determine if the origin HTTPS certificate should be
    validated.
  • follow_redirects: Should the monitor allow following a redirect if
    the origin presents it.

Fixes #113

Updates the `cloudflare_load_balancer_monitor` to configure whether to
validate HTTPS certificates.
Updates the `cloudflare_load_balancer_monitor` resource to configure the
`follow_redirects` attribute.
@ghost ghost added size/S kind/documentation Categorizes issue or PR as related to documentation. labels Feb 4, 2019
@jacobbednarz
Copy link
Member Author

Acceptance tests look good.

TF_ACC=1 go test -v github.com/terraform-providers/terraform-provider-cloudflare/cloudflare -run TestAccCloudflareLoadBalancerMonitor -timeout 120m
=== RUN   TestAccCloudflareLoadBalancerMonitor_Import
=== PAUSE TestAccCloudflareLoadBalancerMonitor_Import
=== RUN   TestAccCloudflareLoadBalancerMonitor_Basic
=== PAUSE TestAccCloudflareLoadBalancerMonitor_Basic
=== RUN   TestAccCloudflareLoadBalancerMonitor_FullySpecified
=== PAUSE TestAccCloudflareLoadBalancerMonitor_FullySpecified
=== RUN   TestAccCloudflareLoadBalancerMonitor_Update
=== PAUSE TestAccCloudflareLoadBalancerMonitor_Update
=== RUN   TestAccCloudflareLoadBalancerMonitor_CreateAfterManualDestroy
=== PAUSE TestAccCloudflareLoadBalancerMonitor_CreateAfterManualDestroy
=== CONT  TestAccCloudflareLoadBalancerMonitor_Import
=== CONT  TestAccCloudflareLoadBalancerMonitor_Basic
=== CONT  TestAccCloudflareLoadBalancerMonitor_Update
=== CONT  TestAccCloudflareLoadBalancerMonitor_FullySpecified
--- PASS: TestAccCloudflareLoadBalancerMonitor_Import (2.10s)
=== CONT  TestAccCloudflareLoadBalancerMonitor_CreateAfterManualDestroy
--- PASS: TestAccCloudflareLoadBalancerMonitor_FullySpecified (2.95s)
--- PASS: TestAccCloudflareLoadBalancerMonitor_Basic (3.72s)
--- PASS: TestAccCloudflareLoadBalancerMonitor_Update (5.81s)
--- PASS: TestAccCloudflareLoadBalancerMonitor_CreateAfterManualDestroy (4.94s)
PASS
ok  	github.com/terraform-providers/terraform-provider-cloudflare/cloudflare	7.064s

@scottrobertson
Copy link

Any movement on this?

@jacobbednarz
Copy link
Member Author

@scottrobertson I've been waiting on confirmation from the issue raisers whether this has addressed their initial problem (see linked issue).

If I don't hear back soon, I'll merge anyway.

@jacobbednarz jacobbednarz merged commit d164409 into cloudflare:master Feb 24, 2019
@jacobbednarz jacobbednarz deleted the add-allow-insecure-and-follow-redirects-support-to-lb branch February 24, 2019 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/documentation Categorizes issue or PR as related to documentation. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants