-
Notifications
You must be signed in to change notification settings - Fork 630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add logic to renew the origin_ca_certificate when expires #2048
Conversation
changelog detected ✅ |
I changed the attribute UpdateContext from Create to Read as the previous was generating uneeded certificates. I could not find any issue with this change as most of the attributes will trigger a new certificate anyway. |
I fixed the merge conflicts and set the Update as Read, as we have the "remaining_days" property that should be set locally, but there is no change to be done upstream. Any property change in a certificate should trigger a renew. |
thanks @peruzzof. i updated the schema definition and called out specifically that a Terraform operation has to be run as this isn't a service side option. |
09f2380
to
b3526c8
Compare
i've also just updated the attribute to be |
This functionality has been released in v3.29.0 of the Terraform Cloudflare Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
This is an attempt to implement #2043.
I based the logic in the hashicorp self signed and AWS providers, I have no previous experience with Go so any suggestion of improvement is welcome.
Closes #2043