Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add consecutive_down and consecutive_up parameters to cloudflare_load_balancer_monitor #1876

Closed
MAN98 opened this issue Aug 31, 2022 · 1 comment · Fixed by #2723
Closed
Labels
kind/enhancement Categorizes issue or PR as related to improving an existing feature. service/load_balancing Categorizes issue or PR as related to the Load Balancing service. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@MAN98
Copy link

MAN98 commented Aug 31, 2022

Current Terraform and Cloudflare provider version

terraform {
required_providers {
vault = {
source = "hashicorp/vault"
}
cloudflare = {
source = "cloudflare/cloudflare"
version = "~> 3.16.0"
}
}
required_version = ">= 1.0"

backend "remote" {
organization = "bmgf"

workspaces {
  name = "tf_cloudflare"
}

}
}

Description

Via the Cloudflare API (https://api.cloudflare.com/#account-load-balancer-monitors-create-monitor) you can set the consecutive_down and consecutive_up parameter values for the Cloudflare Load Balancer Monitor resource but not with the Terraform Provider. Can we have these added?

Use cases

We are managing our LB Monitors via Terraform as with everything else. Having a consecutive_up and consecutive_down parameter will give us more flexibility in fine-tuning the monitors we use for our LB pools.

Potential Terraform configuration

resource "cloudflare_load_balancer_monitor" "lb_monitor" {
type = "https"
expected_body = "Healthy"
expected_codes = "2xx"
method = "GET"
timeout = 5
path = "/healthcheck"
interval = 10
port = 443
retries = 1
description = "monitor for ${var.zone_name}"
header {
header = "Host"
values = [var.zone_name]
}
allow_insecure = true
follow_redirects = false
consecutive_down = 2
}

References

No response

@MAN98 MAN98 added kind/enhancement Categorizes issue or PR as related to improving an existing feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 31, 2022
@jacobbednarz jacobbednarz added triage/accepted Indicates an issue or PR is ready to be actively worked on. service/load_balancing Categorizes issue or PR as related to the Load Balancing service. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 1, 2022
@andmor
Copy link

andmor commented Sep 1, 2022

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Categorizes issue or PR as related to improving an existing feature. service/load_balancing Categorizes issue or PR as related to the Load Balancing service. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
3 participants