Use set instead of to avoid infinite changes

[vavsab]

Closes #1802

[github-actions]

changelog detected ✅

[jacobbednarz]

thanks for the PR! you'll need to update the acceptance tests as well since right now they are based on TypeList - https://github.com/cloudflare/terraform-provider-cloudflare/blob/master/internal/provider/resource_cloudflare_fallback_domain_test.go

[vavsab]

thanks for the PR! you'll need to update the acceptance tests as well since right now they are based on TypeList - https://github.com/cloudflare/terraform-provider-cloudflare/blob/master/internal/provider/resource_cloudflare_fallback_domain_test.go

The test is green now.

[jacobbednarz]

this is odd that the test is passing with the following assertion

resource.TestCheckResourceAttr(name, "domains.0.description", "example domain"),

for TypeSet, the index is a computed hash of the inner elements (such as 12345678). i'll see if i can find an explanation as to why this is still working after it should have broke.

[jacobbednarz]

i had a look into this and it seems like it somehow works with nested schemas. i can't find specifically where the difference in nested vs simple schemas is (that shows the behaviour difference) but it works 🤷

[github-actions]

This functionality has been released in v3.22.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!