Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional port parameter to load balancer monitors #179

Merged
merged 3 commits into from
Jan 4, 2019

Conversation

Seanstoppable
Copy link
Contributor

@ghost ghost added size/L and removed size/XS labels Dec 18, 2018
@@ -236,6 +237,7 @@ resource "cloudflare_load_balancer_monitor" "test" {
path = "/custom"
interval = 60
retries = 5
port = 8080
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the indentation is out here. Would you mind aligning it with the other values?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a problem. Done.

Copy link
Member

@jacobbednarz jacobbednarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this one @Seanstoppable! looks great!

@patryk patryk merged commit 03cb59f into cloudflare:master Jan 4, 2019
@patryk
Copy link
Contributor

patryk commented Jan 4, 2019

Thanks @Seanstoppable.

@Seanstoppable
Copy link
Contributor Author

No problem!

boekkooi-lengoo pushed a commit to boekkooi-lengoo/terraform-provider-cloudflare that referenced this pull request Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants