Allow zone_id to set zone and vice versa
#174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During an import of the `cloudflare_firewall_rule` resource, the `zone_id` is defined within the composite ID. This value is then populated and synced within `resourceCloudflareFirewallRuleRead` to match the expected schema resource. However, we don't currently set zone (the zone name) anywhere. This becomes problematic on subsequent terraform operations as the Read attempts to sync the schema with the firewall rule and ends up attempting to recreate the resource due to detecting a change. This is a similar issue to cloudflare#161 and is addressed in a similar manner. Fixes cloudflare#165
ghost
added
the
|
Yup, you're right. Thanks! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During an import of the
cloudflare_firewall_ruleresource, thezone_idisdefined within the composite ID. This value is then populated and synced
within
resourceCloudflareFirewallRuleReadto match the expected schemaresource. However, we don't currently set zone (the zone name)
anywhere. This becomes problematic on subsequent terraform operations as
the Read attempts to sync the schema with the firewall rule and ends up
attempting to recreate the resource due to detecting a change.
This is a similar issue to #161 and is addressed in a similar manner.
Fixes #165