cloudflare_tunnel_route: read by filtering list #1581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terinjokes
force-pushed
the
tunnel-route-reads
branch
from
84169e4 to
9c33065
Compare
The `GetTunnelRouteForIP` SDK function will return the first route that either exactly matches the specified IP or larger CIDR. If routes exist for both `10.0.0.0/8` and `10.0.0.0/24`, and the latter is accidentally deleted, the SDK function will start returning the former route. This changeset resolves this issue by providing filters to the `ListTunnelRoutes` such that the network subset and superset are both the specific CIDR being managed. The API returns 1 result if there is an exact match, and 0 results otherwise. Bug: K8S-4828
terinjokes
force-pushed
the
tunnel-route-reads
branch
from
9c33065 to
f1b3e34
Compare
9 tasks
|
This functionality has been released in v3.14.0 of the Terraform Cloudflare Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
|
Any chance we'll get a new cloudflare-go and terraform provider release soon to pick up the upstream changes? I tried to use the new |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
GetTunnelRouteForIPSDK function will return the first route thateither exactly matches the specified IP or larger CIDR. If routes exist
for both
10.0.0.0/8and10.0.0.0/24, and the latter is accidentallydeleted, the SDK function will start returning the former route.
This changeset resolves this issue by providing filters to the
ListTunnelRoutessuch that the network subset and superset are boththe specific CIDR being managed. The API returns 1 result if there is an
exact match, and 0 results otherwise.
Bug: K8S-4828