Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match access_policy argument requisites with reality #158

Merged
merged 1 commit into from
Nov 20, 2018

Conversation

bobrik
Copy link
Contributor

@bobrik bobrik commented Nov 19, 2018

Docs have it right:

* `require` - (Optional) A series of access conditions, see below for
  full list.
* `exclude` - (Optional) A series of access conditions, see below for
  full list.
* `include` - (Required) A series of access conditions, see below for
  full list.

This commit makes code match the docs.

Docs have it right:

```
* `require` - (Optional) A series of access conditions, see below for
  full list.
* `exclude` - (Optional) A series of access conditions, see below for
  full list.
* `include` - (Required) A series of access conditions, see below for
  full list.
```

This commit makes code match the docs.
@ghost ghost added the size/XS label Nov 19, 2018
Copy link
Member

@jacobbednarz jacobbednarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦‍♂️ thanks @bobrik!

@jacobbednarz
Copy link
Member

Some additional notes here.

Access Policy definition: https://api.cloudflare.com/#access-policy-properties
Create a new Access policy: https://api.cloudflare.com/#access-policy-create-access-policy

@patryk patryk merged commit aeb3c96 into cloudflare:master Nov 20, 2018
@patryk
Copy link
Contributor

patryk commented Nov 20, 2018

Thanks!

boekkooi-lengoo pushed a commit to boekkooi-lengoo/terraform-provider-cloudflare that referenced this pull request Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants