-
Notifications
You must be signed in to change notification settings - Fork 630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to wait for cert packs to be active #1567
Add ability to wait for cert packs to be active #1567
Conversation
Oops! It looks like no changelog entry is attached to this PR. Please include a release note as described in https://github.com/cloudflare/terraform-provider-cloudflare/blob/master/docs/changelog-process.md. Example:
If you do not require a release note to be included, please add the |
before we consider merging this, we'll also need some tests and to clean up the imports for these files. |
I've cleaned up the imports, what level of testing do you think we need by the way? I can add a I finish my current job on Friday this week so I won't be likely to look at this issue after that point as I don't think I will be using Cloudflare anymore, so any feedback before then would be handy. |
yep, just a check that it ends up in the state is fine. we can also add another test with the |
Understood, I will get this added today. Thanks. |
Added the tests and rebased from master if you can take another look please @jacobbednarz. I don't have a test Cloudflare account that would be safe to run the test suite in (from a brief look at the way they work, the sweepers will destroy unrelated resources) so I don't know if the tests actually pass or not. |
acceptance tests look good
|
This functionality has been released in v3.14.0 of the Terraform Cloudflare Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
This is probably not ready for merge - I made this little patch to test the feature request in #1559 and won't be able to follow up in all likelihood by the time there is a response due to a change in employer (so I will no longer personally be working with Cloudflare - but the use case for the employer is still valid/relevant), but I didn't want to just delete the local code.
Please feel free to use/modify/drop this as needed.
It adds a new option to the
cloudflare_certificate_pack
resource to block/wait on creation until all certificates in the pack are marked as active in the API - with the aim of this making use ofcreate_before_destroy
less likely to cause service disruption on updates.