Fix 'edge_ip_connectivity' state persistence

[kireledan]

Fixes #1500

This PR fixes the edge_ip_connectivity value from not being stored in the terraform state when being read.

Tested with the resource below and was able to get a No changes after applying and running another plan. As well as after importing the resource.

resource "cloudflare_spectrum_application" "myapp-east-sfe" {
  ip_firewall    = true
  origin_port    = 25
  protocol       = "tcp/25"
  proxy_protocol = "v1"
  tls            = "off"
  traffic_type   = "direct"
  edge_ip_connectivity = "ipv4"
  zone_id        = "redacted"
  dns {
    name = "myapp-test-spectrum.redacted.net"
    type = "CNAME"
  }
  origin_dns {
    name = "myapp-test-spectrum.redacted.net"
  }
}

[github-actions]

Oops! It looks like no changelog entry is attached to this PR. Please include a release note as described in https://github.com/cloudflare/terraform-provider-cloudflare/blob/master/docs/changelog-process.md.

Example:

```release-note:TYPE
Release note
```

If you do not require a release note to be included, please add the workflow/skip-changelog-entry label.

[jacobbednarz]

you’ll need to rename the CHANGELOG file to match the PR number.

can you please extend a test case to cover this field being saved to state? https://github.com/cloudflare/terraform-provider-cloudflare/blob/master/cloudflare/resource_cloudflare_spectrum_application_test.go has examples to get you started.

[kireledan]

Ah gotcha! Thought it was the Issue number.

Ill add that test in too 👍

[jacobbednarz]

acceptance tests are passing locally

TF_ACC=1 go test $(go list ./...) -v -run "^TestAccCloudflareSpectrumApplication_" -count 1 -parallel 1 -timeout 120m -parallel 1
?   	github.com/cloudflare/terraform-provider-cloudflare	[no test files]
=== RUN   TestAccCloudflareSpectrumApplication_Import
=== PAUSE TestAccCloudflareSpectrumApplication_Import
=== RUN   TestAccCloudflareSpectrumApplication_Basic
--- PASS: TestAccCloudflareSpectrumApplication_Basic (13.27s)
=== RUN   TestAccCloudflareSpectrumApplication_OriginDNS
--- PASS: TestAccCloudflareSpectrumApplication_OriginDNS (11.70s)
=== RUN   TestAccCloudflareSpectrumApplication_OriginPortRange
--- PASS: TestAccCloudflareSpectrumApplication_OriginPortRange (11.55s)
=== RUN   TestAccCloudflareSpectrumApplication_Update
--- PASS: TestAccCloudflareSpectrumApplication_Update (20.26s)
=== RUN   TestAccCloudflareSpectrumApplication_CreateAfterManualDestroy
--- PASS: TestAccCloudflareSpectrumApplication_CreateAfterManualDestroy (23.64s)
=== RUN   TestAccCloudflareSpectrumApplication_EdgeIPConnectivity
--- PASS: TestAccCloudflareSpectrumApplication_EdgeIPConnectivity (11.32s)
=== CONT  TestAccCloudflareSpectrumApplication_Import
--- PASS: TestAccCloudflareSpectrumApplication_Import (15.29s)
PASS
ok  	github.com/cloudflare/terraform-provider-cloudflare/cloudflare	107.439s
?   	github.com/cloudflare/terraform-provider-cloudflare/tools/cmd/changelog-check	[no test files]
?   	github.com/cloudflare/terraform-provider-cloudflare/tools/cmd/maintainer-only-file-check	[no test files]
?   	github.com/cloudflare/terraform-provider-cloudflare/tools/cmd/tf-log-check	[no test files]
?   	github.com/cloudflare/terraform-provider-cloudflare/version	[no test files]

[jacobbednarz]

thank you @kireledan for this one!