-
Notifications
You must be signed in to change notification settings - Fork 630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update validation records/errors for custom_hostname
and certificate_pack
#1424
update validation records/errors for custom_hostname
and certificate_pack
#1424
Conversation
Oops! It looks like no changelog entry is attached to this PR. Please include a release note as described in https://github.com/cloudflare/terraform-provider-cloudflare/blob/master/docs/changelog-process.md. Example:
If you do not require a release note to be included, please add the |
@nickysemenza could you move the CHANGELOG entry to the file as the documentation mentions? that will allow it post merge to be picked up correctly. |
…te_pack` * `custom_hostname`: validation tokens are now an array (`validation_records`) instead of a top level, but the only top level record that was previously here was for cname validation, txt/http/email were entirely missing. * `custom_hostname`: also adds missing `validation_errors`, and `certificate_authority` * `certificate_pack`: adds `validation_errors` and `validation_records` with same format as custom hostnames. relies of lib behavior added in cloudflare/cloudflare-go#796
305855d
to
4ca3bcb
Compare
acceptance tests are green
|
711522e
to
32b57cc
Compare
0eba90c
to
1703403
Compare
relies of lib behavior added in cloudflare/cloudflare-go#796