-
Notifications
You must be signed in to change notification settings - Fork 632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds support for Magic Transit IPsec tunnels #1404
Conversation
|
||
func resourceCloudflareIPsecTunnelCreate(d *schema.ResourceData, meta interface{}) error { | ||
client := meta.(*cloudflare.API) | ||
client.AccountID = d.Get("account_id").(string) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this will now need to update that we are not using the api.AccountID field and instead, pull it from the schema.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, I hope I didn't miss any. I am actually not sure, how does meta behave when run in parallel on different resources with different account IDs? I think meta is not really protected from this, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i don't think so but i'd need to confirm the internals. it shouldn't be an issue though as in the Tenant use case, the client will be the same (authn/z) but the URLs will need to swap based on the account.
Magic Team implemented a fix for the API time outs we were observing. Acceptance Tests started to pass
|
6c91994
to
c03cde6
Compare
c03cde6
to
b68d3ca
Compare
@cehrig this now has the latest cloudflare-go changes. do you mind running the acceptance tests against your account before i merge? |
Thanks @jacobbednarz, looking good!
|
This PR adds a new resource for managing IPsec tunnels. The resource layout looks as follows:
A pending cloudflare-go PR cloudflare/cloudflare-go#787 is required for this feature. The provided acceptance tests will only be working when using an account with Magic Transit support.
The Create and Update methods occasionally run into a time out. I am checking with Magic team why that happens.