add dns_logs to logpush schema validation #1400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops! It looks like no changelog entry is attached to this PR. Please include a release note as described in https://github.com/cloudflare/terraform-provider-cloudflare/blob/master/docs/changelog-process.md. Example: If you do not require a release note to be included, please add the |
trjstewart
force-pushed
the
logpush_dns_logs
branch
from
a88009a to
3376d8d
Compare
|
looks good; let's get the documentation updated (https://github.com/cloudflare/terraform-provider-cloudflare/blob/master/website/docs/r/logpush_job.html.markdown) and this is good to merge. |
trjstewart
force-pushed
the
logpush_dns_logs
branch
from
722c560 to
b9f9b10
Compare
|
thank you @trjstewart 🤙 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dataset
dns_logsis supported by the Logpush service but not included in the schema validation for thecloudflare_logpush_jobresource.I have used this locally and all looks to be working as expected.